Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sitecore-jss][templates/nextjs-xmcloud] Enable site query in XMCloud #1739

Merged
merged 7 commits into from
Feb 16, 2024

Conversation

art-alexeyenko
Copy link
Contributor

@art-alexeyenko art-alexeyenko commented Feb 15, 2024

Description / Motivation

SiteInfoGraphQLService now accepts a boolean xmCloud parameter. The parameter enables using site query - and it will be enabled by default when xmcloud addon is used via clientConfig.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@art-alexeyenko art-alexeyenko requested a review from a team February 15, 2024 19:52
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one other minor suggestion, otherwise looks good to me!

@art-alexeyenko art-alexeyenko merged commit 7c905ae into dev Feb 16, 2024
1 check passed
@art-alexeyenko art-alexeyenko deleted the feature/jss-1380-site-query-xmcloud branch February 16, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants