Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XM Cloud][Next.js] Editing Configuration Endpoint - fix forbidden response for Vercel #1734

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

yavorsk
Copy link
Contributor

@yavorsk yavorsk commented Feb 13, 2024

Description / Motivation

This PR updates editing config middleware to return object when editing secret is missing or wrong. This fixes config endpoint behavior in vercel environment.

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you, please, update the CHANGELOG, PR link needs to be included
Also update the title of PR it should follow our rules

@yavorsk yavorsk changed the title Feature/jss 1635 [XM Cloud][Next.js] Editing Configuration Endpoint - fix forbidden response for Vercel Feb 13, 2024
Copy link
Contributor

@illiakovalenko illiakovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@illiakovalenko illiakovalenko merged commit c144a05 into dev Feb 13, 2024
1 check passed
@illiakovalenko illiakovalenko deleted the feature/JSS-1635 branch February 13, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants