[Chore] Upgrade to Node.js 20.x

CHANGELOG.md

@@ -15,6 +15,10 @@ Our versioning strategy is as follows:
 
 * `[sitecore-jss]` `[templates/nextjs-xmcloud]` Load the content styles for the RichText component [#1670](https://github.com/Sitecore/jss/pull/1670)
 
+### 🧹 Chores
+
+* Upgrade to Node.js 20.x ([#1679](https://github.com/Sitecore/jss/pull/1679))
+
 ### 🐛 Bug Fixes
 
 * `[templates/node-headless-ssr-proxy]` `[node-headless-ssr-proxy]` Add sc_site qs parameter to Layout Service requests by default ([#1660](https://github.com/Sitecore/jss/pull/1660))

azure-pipelines.yml

@@ -43,7 +43,7 @@ variables:
 steps:
 - task: NodeTool@0
   inputs:
-    versionSpec: '16.x'
+    versionSpec: '20.x'
 - script: |
     yarn cache clean --all && yarn install --immutable
   displayName: 'yarn install - initial'

packages/create-sitecore-jss/package.json

@@ -6,7 +6,7 @@
   "scripts": {
     "build": "npm run clean && tsc && ts-node ./scripts/build-templates.ts",
     "clean": "del-cli dist types",
-    "lint": "eslint --no-eslintrc -c .eslintrc ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.ts\"",
     "watch": "ts-node ./scripts/watch-templates.ts",
     "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
     "coverage": "nyc npm test"

packages/sitecore-jss-angular/package.json

@@ -4,7 +4,7 @@
   "description": "",
   "scripts": {
     "build": "ng-packagr -p ng-package.json",
-    "lint": "eslint ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.ts\"",
     "test": "ng test",
     "test:watch": "ng test --no-single-run --browsers Chrome",
     "coverage": "ng test --code-coverage",

packages/sitecore-jss-angular/src/test.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-unused-vars */
 // This file is required by karma.conf.js and loads recursively all the .spec and framework files
 import 'zone.js';
 import 'zone.js/testing';

packages/sitecore-jss-cli/package.json

@@ -9,7 +9,7 @@
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "watch": "npm run build -- --watch",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.ts\"",
     "prepublishOnly": "npm run build",
     "jss": "node ./dist/cjs/bin/jss.js",
     "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\"",

packages/sitecore-jss-dev-tools/package.json

@@ -9,7 +9,7 @@
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "watch": "npm run build -- --watch",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.ts\"",
     "test": "mocha --require ts-node/register -r tsconfig-paths/register  \"./src/**/*.test.ts\"",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test",

packages/sitecore-jss-dev-tools/src/templating/react/generate-component-builder.ts

@@ -36,9 +36,10 @@ export function generateComponentBuilder({
 
 /**
  * Watch for changes to component builder sources
- * @param {string} componentRootPath root path to components
- * @param {PackageDefinition[]} packages packages to include in component builder
- * @param {ComponentFile[]} components components to include in component builder
+ * @param {object} config configuration for component builder watcher
+ * @param {string} config.componentRootPath root path to components
+ * @param {PackageDefinition[]} config.packages packages to include in component builder
+ * @param {ComponentFile[]} config.components components to include in component builder
  */
 export function watchComponentBuilder({
   componentRootPath,

packages/sitecore-jss-forms/package.json

@@ -7,7 +7,7 @@
   "scripts": {
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.ts\"",
     "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test",

packages/sitecore-jss-nextjs/package.json

@@ -7,7 +7,7 @@
   "scripts": {
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.tsx ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.tsx\" \"./src/**/*.ts\"",
     "test": "mocha --require ./test/setup.js \"./src/**/*.test.ts\" \"./src/**/*.test.tsx\" --exit",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test",

packages/sitecore-jss-nextjs/src/editing/editing-render-middleware.ts

@@ -78,7 +78,7 @@ export class EditingRenderMiddleware {
 
   /**
    * Gets query parameters that should be passed along to subsequent requests
-   * @param query Object of query parameters from incoming URL
+   * @param {Object} query Object of query parameters from incoming URL
    * @returns Object of approved query parameters
    */
   protected getQueryParamsForPropagation = (

packages/sitecore-jss-proxy/package.json

@@ -8,7 +8,7 @@
   "scripts": {
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.ts\"",
     "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test",

packages/sitecore-jss-react-forms/package.json

@@ -7,7 +7,7 @@
   "scripts": {
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.tsx ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.tsx\" \"./src/**/*.ts\"",
     "test": "mocha --require ts-node/register/transpile-only --require ./src/tests/shim.ts ./src/tests/jsdom-setup.ts ./src/tests/enzyme-setup.ts \"./src/**/*.test.tsx\" --exit",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test",

packages/sitecore-jss-react-native/package.json

@@ -8,7 +8,7 @@
     "clean": "del-cli dist types",
     "typecheck": "tsc",
     "fixcrlf": "eslint --rule 'linebreak-style: [\"error\", \"unix\"]' --ext .ts --no-eslintrc --fix ./dist",
-    "lint": "eslint ./src/**/*.tsx ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.tsx\" \"./src/**/*.ts\"",
     "test": "jest",
     "prepublishOnly": "npm test && npm run build",
     "coverage": "jest --config ./jest.config.coverage.js",

packages/sitecore-jss-react/package.json

@@ -7,7 +7,7 @@
   "scripts": {
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.tsx ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.tsx\" \"./src/**/*.ts\"",
     "test": "mocha --require ts-node/register/transpile-only --require ./src/tests/shim.ts ./src/tests/jsdom-setup.ts ./src/tests/enzyme-setup.ts \"./src/**/*.test.ts\" \"./src/**/*.test.tsx\" --exit",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test",

packages/sitecore-jss-rendering-host/package.json

@@ -7,7 +7,7 @@
   "scripts": {
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.ts\"",
     "test": "mocha --require ts-node/register/transpile-only \"./src/**/*.test.ts\"",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test",

packages/sitecore-jss-vue/package.json

@@ -8,7 +8,7 @@
   "scripts": {
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.ts\"",
     "test": "jest",
     "prepublishOnly": "npm run build",
     "coverage": "jest --config ./jest.config.coverage.js",

packages/sitecore-jss/package.json

@@ -7,7 +7,7 @@
   "scripts": {
     "build": "npm run clean && tsc -p tsconfig.json && tsc -p tsconfig-esm.json",
     "clean": "del-cli dist types",
-    "lint": "eslint ./src/**/*.ts",
+    "lint": "eslint \"./src/**/*.ts\"",
     "test": "mocha --require ts-node/register \"./src/**/*.test.ts\"",
     "prepublishOnly": "npm run build",
     "coverage": "nyc npm test",