Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Upgrade to Node.js 20.x #1679

Merged
merged 3 commits into from
Dec 4, 2023
Merged

[Chore] Upgrade to Node.js 20.x #1679

merged 3 commits into from
Dec 4, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Dec 1, 2023 •
edited
Loading

Description / Motivation

  • Updated repository to use Node.js v20.x (LTS)
  • Fixed the 'Command line is too long' error that occurred when running 'npm run lint:packages'. The issue was due to the eslint command interpreting the regular expression as a list of files to be passed via the command line. The solution was to pass the regular expression as a string to the eslint command..
  • Fixed minor eslint issues, not related to upgrade

Testing Details

  • Unit Test Added
  • Manual Test/Other (Please elaborate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko added do-not-merge do-not-review PR's not ready for review labels Dec 1, 2023
@illiakovalenko illiakovalenko removed do-not-merge do-not-review PR's not ready for review labels Dec 4, 2023
@illiakovalenko illiakovalenko changed the title Updated to node.js 20.10.0 [Chore] Updated repository to use node.js 20.10.0 Dec 4, 2023
@illiakovalenko illiakovalenko changed the title [Chore] Updated repository to use node.js 20.10.0 [Chore] Updated repository to use node.js 20.x Dec 4, 2023
@illiakovalenko illiakovalenko changed the title [Chore] Updated repository to use node.js 20.x [Chore] Upgrade to Node.js 20.x Dec 4, 2023
@illiakovalenko illiakovalenko merged commit 786913d into dev Dec 4, 2023
1 check was pending
@illiakovalenko illiakovalenko deleted the feature/JSS-1171 branch December 4, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@illiakovalenko