-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nextjs/template][sitecore-jss-nextjs] On demand ISR #1674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't have time to do a full review, but here is some preliminary feedback
packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/revalidate.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/revalidate.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/revalidate.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/revalidate.ts
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved by mistake, need to resolve comments first :)
Co-authored-by: Illia Kovalenko <23364749+illiakovalenko@users.noreply.github.com>
Co-authored-by: Illia Kovalenko <23364749+illiakovalenko@users.noreply.github.com>
…ss into feature/jss-378-on-demand-isr
packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/revalidate.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.test.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/revalidate.ts
Outdated
Show resolved
Hide resolved
…i/revalidate.ts Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor things this round, conditionally approving. Nice work!
packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/revalidate.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/revalidate.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/sitecore-jss-nextjs/src/revalidate/revalidate-middleware.ts
Outdated
Show resolved
Hide resolved
packages/create-sitecore-jss/src/templates/nextjs/src/pages/api/revalidate.ts
Outdated
Show resolved
Hide resolved
…i/revalidate.ts Co-authored-by: Adam Brauer <400763+ambrauer@users.noreply.github.com>
Adds On-demand ISR feature from Nextjs
Description / Motivation
Testing Details
Types of changes