Introduce a CLI tool for deploying projects #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katiemckeon
commented
Jan 28, 2025
Comment on lines
+159
to
+161
| let bundle = std::env::var("VCR_PATH") | ||
| .unwrap_or_else(|_| "tests/recordings/replay.vcr.json".to_string()); | ||
| let bundle_path = std::path::PathBuf::from(&bundle); |
There was a problem hiding this comment.
needed so that sindri-cli can also access the middleware recording location
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔄 Pull Request
📝 Description
While the sindri-js CLI is more feature complete, some users may prefer a CLI installed via the rust package manager. This PR introduces the
cargo sindri deployfunctionality to upload a circuit to Sindri.🔗 Related Tickets & Documents
📋 Type of PR (check all applicable)
💭 Developer Notes
Originally, we put the CLI as a bin in
sindri-rssince it is self-contained as one file. Whilecargo buildhad no issue,cargo installkept attempting to include the optionalsp1-sdk-v3package which has a conflicting reqwest-middleware dependency.🧪 Testing Instructions
The unit test ensuring that error messages pass through has been added to the github workflow. We are still in the process of operationalizing the VCR functionality so that integration tests may also be run thru CI.
✅ Testing Status