Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Dutch BBAN check #493

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Remove Dutch BBAN check #493

merged 1 commit into from
Jan 9, 2024

Conversation

Simplify
Copy link
Owner

@Simplify Simplify commented Jan 9, 2024

Fixes and closes #487 and #415

Changes proposed in this pull request:

  • Remove Dutch BBAN check. It's no longer required for Dutch bank accounts to be elf-proof as IBAN is used for all payments and IBAN itself has checksum.

Tests (check [x] one of those)

  • I have added test(s)
  • My change does not need new tests

ChangeLog

  • I have added entry in ChangeLog file (if not, please do so)

@Simplify
Remove Dutch BBAN check
77510d2 
Fixes and closes #487
@coveralls
Copy link

Coverage Status

coverage: 99.401% (-0.03%) from 99.43%
when pulling 77510d2 on remove-nl-bban-check
into 597937a on master.

@Simplify Simplify merged commit 1b27690 into master Jan 9, 2024
10 of 12 checks passed
@Simplify Simplify deleted the remove-nl-bban-check branch January 9, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation is not correct for Dutch bank account number.
2 participants
@Simplify @coveralls