Bugfix/null notifications (#2)

Notifications with no content will now not be echoed by the app
SilverTuxedo · Dec 23, 2020 · 12e3343 · 12e3343
1 parent d718470
commit 12e3343
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/app/build.gradle b/app/build.gradle
@@ -9,7 +9,7 @@ android {
         minSdkVersion 26
         targetSdkVersion 30
         versionCode 1
-        versionName "1.0"
+        versionName "1.0.1"
 
         testInstrumentationRunner "androidx.test.runner.AndroidJUnitRunner"
     }

diff --git a/app/src/main/java/com/talmar/conveyor/notificationFilters/NullContentFilter.java b/app/src/main/java/com/talmar/conveyor/notificationFilters/NullContentFilter.java
@@ -0,0 +1,20 @@
+package com.talmar.conveyor.notificationFilters;
+
+import android.app.Notification;
+import android.service.notification.StatusBarNotification;
+
+import androidx.annotation.NonNull;
+
+/**
+ * Filters out notifications that don't have a title and text.
+ */
+public class NullContentFilter implements INotificationFilter {
+
+    @Override
+    public boolean shouldIgnoreNotification(@NonNull StatusBarNotification sbn) {
+        Notification notification = sbn.getNotification();
+
+        return notification.extras.get(Notification.EXTRA_TITLE) == null
+                && notification.extras.get(Notification.EXTRA_TEXT) == null;
+    }
+}
diff --git a/app/src/main/java/com/talmar/conveyor/services/NotificationService.java b/app/src/main/java/com/talmar/conveyor/services/NotificationService.java
@@ -16,6 +16,7 @@
 import com.talmar.conveyor.NotificationEchoing;
 import com.talmar.conveyor.notificationFilters.CategoryFilter;
 import com.talmar.conveyor.notificationFilters.INotificationFilter;
+import com.talmar.conveyor.notificationFilters.NullContentFilter;
 import com.talmar.conveyor.notificationFilters.OwnNotificationFilter;
 import com.talmar.conveyor.notificationFilters.SelectedAppsFilter;
 import com.talmar.conveyor.notificationFilters.SummaryNotificationFilter;
@@ -47,6 +48,7 @@ public void onCreate() {
                 new OwnNotificationFilter(),
                 new SummaryNotificationFilter(),
                 new CategoryFilter(),
+                new NullContentFilter(),
                 new SelectedAppsFilter(sharedPreferences),
                 new UserPresenceFilter(this, sharedPreferences)
         };