Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚥💧 ↝ [SSG-69 SSG-64 SSG-78]: New Community Missions, Beginning #Chapter-2 flow #165

Merged
merged 14 commits into from
Dec 1, 2024

Conversation

Gizmotronn
Copy link
Member

@Gizmotronn Gizmotronn commented Dec 1, 2024

Broad goal - users can travel again ✅, and there's a clear mission group across expeditions and exoplanet colonisation ⏳ (planned). Clear mission goals for each pathway and structure on different location types ⏳. Increased collaboration, communication, item sharing, consensus & surveyor (introduction through missions) and post cards, sharing to posts table (new) and external networks. New design for StarnetLayout

Huly®: STAR_-150

… mission list with increased relevance is in the final stages️
…ining ops for this sprint, preparing for the follow up with the new C2
Copy link

height bot commented Dec 1, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member Author

@Gizmotronn Gizmotronn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't get everything done, but some significant milestones were reached and we have a strong plan going forward. Community missions are done, stations are next, transport is also back in play

@Gizmotronn Gizmotronn merged commit 4758ea7 into main Dec 1, 2024
4 of 5 checks passed
@Gizmotronn Gizmotronn deleted the SSG-69 branch December 1, 2024 03:19

// Draw the image onto the canvas
const img = new Image();
img.src = imageUrl;

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
is reinterpreted as HTML without escaping meta-characters.

Copilot Autofix AI 3 months ago

To fix the problem, we need to ensure that the imageUrl is properly sanitized before being used. Since URL.createObjectURL(file) is generally safe, we can add a check to ensure that the file type is an image before creating the URL. This will prevent non-image files from being used, which could potentially contain malicious content.

  • Add a check to ensure the uploaded file is an image.
  • Only create the object URL if the file type is an image.
Suggested changeset 1
app/starnet/annotation/page.tsx

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/app/starnet/annotation/page.tsx b/app/starnet/annotation/page.tsx
--- a/app/starnet/annotation/page.tsx
+++ b/app/starnet/annotation/page.tsx
@@ -20,3 +20,3 @@
     const file = event.target.files?.[0];
-    if (file) {
+    if (file && file.type.startsWith('image/')) {
       const url = URL.createObjectURL(file);
EOF
@@ -20,3 +20,3 @@
const file = event.target.files?.[0];
if (file) {
if (file && file.type.startsWith('image/')) {
const url = URL.createObjectURL(file);
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant