-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Arduino environment/analog readout hardware layer #211
Conversation
…he code of temperature/humidity and pressure measurements
Please rebase to check if pipeline is now working. |
* PRJ: Update workflow (verilog version, python version) --------- Co-authored-by: Yannick Dieter <yannick.manuel.dieter@cern.ch> Co-authored-by: Christian Bespin <11457592+cbespin@users.noreply.github.com> Co-authored-by: Christian Bespin <silab@debian-BULLSEYE-live-builder-AMD64>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not enough experience with arduino to comment on the ino files, but if it works, I trust you. Nicely commented for those who want to contribute!
Only thing is the python-style function naming ;)
ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the changes! I will merge this now. The next release is coming closer 🎊
An Arduino firmware based on the NTC readout firmware has been added to read out the pure analog values. This firmware helps to standardize experimental setups with multiple Arduino readout boards by moving the temperature/humidity/pressure calculation to the 'EnvironmentReadout' class instances in the hardware drivers list. It can also reduce the number of different Arduino firmwares required for larger setups to one.
This step was also necessary for temperature-corrected humidity measurements in more extreme measurement ranges.
The
EnvironmentReadout
class has readout functions for temperature, humidity and pressure. The calibration/conversion parameters can be set as init parameters of the corresponding hardware driver, as follows:TL;DR: These changes simplify the readout of multiple Arduino "Environment" boards by moving the hardware-dependent calibration constants to the hardware driver configuration as an init parameter. The conversion from analog readout to temperature/humidity/pressure measurement is done by the hardware driver.
Optional improvements: