make cookies http-only, allow to set secure and domain #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P4sca1
force-pushed
the
cookie-security
branch
from
8a9a096 to
0b4b73b
Compare
Signed-off-by: Pascal Sthamer <10992664+P4sca1@users.noreply.github.com>
P4sca1
force-pushed
the
cookie-security
branch
from
0b4b73b to
e2fea41
Compare
Cheers! As long as we keep both |
|
@frikky This MR Is now ready for review. I cleaned up the code by moving the cookie construction into a function and allowed to change the cookie parameters secure and http-only via env variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Shuffle/Shuffle#1604