Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MCMC sampling considering multivariate distribution of each hydrodynamic maneuvering coefficient #64

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

hinata235
Copy link
Contributor

Overview
This pull request introduces a new feature to the existing MCMC implementation create_model_for_mcmc_sample_mmg by incorporating a multivariate distribution as the prior. With this enhancement, posterior samples that preserve correlations between parameters can be used as the prior, enabling more realistic Bayesian updating.

Background and Motivation
• Background:
The current implementation treats the distributions as independent, without considering any correlations between parameters.
• Motivation:
In many real-world scenarios, parameters often exhibit correlations. By leveraging multiple dispatch to handle a multivariate normal distribution as the prior, we achieve more flexible and realistic sampling.

Implementation Details
• New functionality has been added using multiple dispatch to handle a multivariate distribution as the prior in functions that previously used independent distributions.

Testing
• Test cases have been added in test/runtests.jl for sample generation from the multivariate distribution, and functionality has been confirmed to work as expected.

taiga4112 and others added 3 commits June 20, 2024 11:18
Considering wind force and moment in MMG 3DOF model
Add compat of ForwardDiff, KernelDensity
@taiga4112 taiga4112 changed the base branch from main to dev February 24, 2025 06:07
@taiga4112 taiga4112 changed the title initial MCMC sampling considering multivariate distribution of each hydrodynamic maneuvering coefficient Feb 24, 2025
@taiga4112 taiga4112 self-requested a review February 24, 2025 06:34
@taiga4112 taiga4112 self-assigned this Feb 24, 2025
@taiga4112 taiga4112 added the enhancement New feature or request label Feb 24, 2025
Copy link
Contributor

@taiga4112 taiga4112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!!

@taiga4112 taiga4112 merged commit fbdd8fd into ShipMMG:dev Feb 24, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants