Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback search if container ip is empty. Updated install command in readme #10

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

bschulz87
Copy link

This PR adds a fallback search in containers network settings if the regular container ip is an empty string.

Without this patch i got an error when using the proxy connection:

Can't forward traffic to backend tcp/:3306: ssh: rejected: connect failed (Temporary failure in name resolution)
Docker version 19.03.5, build 633a0ea838 (Remote Host)

I also updated the readme to use go install instead of go get

go install, with or without a version suffix (as described above), is now the recommended way to build and install packages in module mode. go get should be used with the -d flag to adjust the current module's dependencies without building packages, and use of go get to build and install packages is deprecated. In a future release, the -d flag will always be enabled. (https://tip.golang.org/doc/go1.16#modules)

@bschulz87
Copy link
Author

Also feel free to remove the install change if i made a mistake here. I'm not super familiar with the go ecosystem to be honest.

@relistan
Copy link
Contributor

cc @danpilch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants