forked from apache/flink
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[FLINK-32137][flamegraph] Added filtering of lambdas when building fl…
…ame graphs
- Loading branch information
1 parent
1ae8e40
commit 9805724
Showing
3 changed files
with
156 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
...test/java/org/apache/flink/runtime/webmonitor/threadinfo/VertexFlameGraphFactoryTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one | ||
| * or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information | ||
| * regarding copyright ownership. The ASF licenses this file | ||
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.flink.runtime.webmonitor.threadinfo; | ||
|
|
||
| import org.apache.flink.runtime.executiongraph.ExecutionAttemptID; | ||
| import org.apache.flink.runtime.executiongraph.ExecutionGraphID; | ||
| import org.apache.flink.runtime.jobgraph.JobVertexID; | ||
| import org.apache.flink.runtime.messages.ThreadInfoSample; | ||
| import org.apache.flink.runtime.scheduler.strategy.ExecutionVertexID; | ||
| import org.apache.flink.util.TestLogger; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
|
|
||
| import java.lang.management.ManagementFactory; | ||
| import java.lang.management.ThreadInfo; | ||
| import java.util.ArrayList; | ||
| import java.util.Collection; | ||
| import java.util.HashMap; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
| import java.util.function.Supplier; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThat; | ||
| import static org.assertj.core.api.Assertions.fail; | ||
|
|
||
| /** Tests for {@link VertexFlameGraphFactory}. */ | ||
| public class VertexFlameGraphFactoryTest extends TestLogger { | ||
| /** Tests that lambda class names are cleaned up inside the stack traces. */ | ||
| @Test | ||
| public void testLambdaClassNamesCleanUp() { | ||
| Map<ExecutionAttemptID, Collection<ThreadInfoSample>> samplesBySubtask = generateSamples(); | ||
|
|
||
| VertexThreadInfoStats sample = new VertexThreadInfoStats(0, 0, 0, samplesBySubtask); | ||
|
|
||
| VertexFlameGraph graph = VertexFlameGraphFactory.createFullFlameGraphFrom(sample); | ||
| int encounteredLambdas = verifyRecursively(graph.getRoot()); | ||
| if (encounteredLambdas == 0) { | ||
| fail("No lambdas encountered in the test, cleanup functionality was not tested"); | ||
| } | ||
| } | ||
|
|
||
| private int verifyRecursively(VertexFlameGraph.Node node) { | ||
| String location = node.getStackTraceLocation(); | ||
| int lambdas = 0; | ||
| if (location.contains("$Lambda$")) { | ||
| lambdas++; | ||
| // com.example.ClassName.method:123 | ||
| // -> com.example.ClassName.method | ||
| // -> com.example.ClassName | ||
| String locationWithoutLineNumber = location.substring(0, location.lastIndexOf(":")); | ||
| String className = | ||
| locationWithoutLineNumber.substring( | ||
| 0, locationWithoutLineNumber.lastIndexOf(".")); | ||
| assertThat(className).endsWith("$Lambda$0/0"); | ||
| } | ||
| return lambdas + node.getChildren().stream().mapToInt(this::verifyRecursively).sum(); | ||
| } | ||
|
|
||
| private Map<ExecutionAttemptID, Collection<ThreadInfoSample>> generateSamples() { | ||
| ThreadInfoSample sample1 = ThreadInfoSample.from(getStackTraceWithLambda()).get(); | ||
|
|
||
| List<ThreadInfoSample> samples = new ArrayList<>(); | ||
| samples.add(sample1); | ||
|
|
||
| ExecutionAttemptID executionAttemptID = | ||
| new ExecutionAttemptID( | ||
| new ExecutionGraphID(), new ExecutionVertexID(new JobVertexID(), 0), 0); | ||
|
|
||
| Map<ExecutionAttemptID, Collection<ThreadInfoSample>> result = new HashMap<>(); | ||
| result.put(executionAttemptID, samples); | ||
|
|
||
| return result; | ||
| } | ||
|
|
||
| private ThreadInfo getStackTraceWithLambda() { | ||
| Supplier<ThreadInfo> r1 = | ||
| () -> | ||
| ManagementFactory.getThreadMXBean() | ||
| .getThreadInfo(Thread.currentThread().getId(), Integer.MAX_VALUE); | ||
| Supplier<ThreadInfo> r2 = () -> r1.get(); | ||
| return r2.get(); | ||
| } | ||
| } |