Skip to content

Commit

Permalink
Referenced wrong commit, double oops
Browse files Browse the repository at this point in the history
  • Loading branch information
SeongGino authored Apr 8, 2024
1 parent 94b65d4 commit 719ed9c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Game config files are searched in `%LOCALAPPDATA%/QMamehook/ini`, and the progra

Unfortunately, QMamehook's exit signal isn't properly hooked up yet, so it doesn't do any cleanup and "eject" any detected serial devices that may have been open at that moment like it should. For now, QMamehook must be closed *while no game/config is open* - alternatively, this can be resolved by simply unplugging and re-plugging the gun controller back into your computer. Since this shouldn't happen under normal expected use (outside of quick testing), that's why it's a low priority issue at the moment.

The reason this happens is because of how QT handles Signals & Slots - or rather, how it *doesn't* handle them for QCoreApplications (i.e. console apps). QMamehook's codebase was established under the assumption that signals would be used as the basis for reading network inputs, but this approach was deemed to be flawed and the method was switched to manual polling/exhausting the TCP buffer until it's empty ([2b5236d](https://github.com/SeongGino/QMamehook/commit/2b5236d3f655f66d161d95ca1505faec8470b89e)). Therefore, there's no real reason to use the bodged-together program template anymore that's currently in use. I'll move everything back to `main.cpp` at some point in the future, which by then should allow me to do proper cleanup and therefore resolve this issue.
The reason this happens is because of how QT handles Signals & Slots - or rather, how it *doesn't* handle them for QCoreApplications (i.e. console apps). QMamehook's codebase was established under the assumption that signals would be used as the basis for reading network inputs, but this approach was deemed to be flawed and the method was switched to manual polling/exhausting the TCP buffer until it's empty ([279e88b](https://github.com/SeongGino/QMamehook/commit/279e88b8e5589abff8a868ee548883bb46317e36)). Therefore, there's no real reason to use the bodged-together program template anymore that's currently in use. I'll move everything back to `main.cpp` at some point in the future, which by then should allow me to do proper cleanup and therefore resolve this issue.

## Building:
#### Requires `qt-base` & `qt-serialport` (QT5/QT6)
Expand Down

0 comments on commit 719ed9c

Please sign in to comment.