Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return none from artifact_at #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rickwalder
Copy link
Contributor

closes #48

@smallsco
Copy link
Contributor

smallsco commented Nov 8, 2023

Hi @rickwalder ,

This is a great addition, unfortunately however it will break any customer code that assumes container.artifact_at() will always return an Artifact or raise a KeyError.

For that reason, I don't think we can accept this for the 1.x branch, which must maintain backward compatibility.

I would like to keep the PR open though, as incorporating this change makes sense for when we eventually publish a v2.0 of the library and can break BC at that point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

container.artifact_at raises KeyError instead of returning None for empty, valid wells
2 participants