Making namespace package #46
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallsco
reviewed
Jul 27, 2023
There was a problem hiding this comment.
I don't see any major blockers, but we need to hold off from releasing this until we can get CI back up and running and test with all the Python versions that we support.
Will the namespace changes affect backwards compatibility at all? Does this warrant a bump to version 2.0?
CHANGELOG.md
Outdated
| - | ||
| - (#42) Improved documentation, testing and function naming around container types and well ordering | ||
| - (#43) Added Step Setup state to Step Runner. | ||
|
|
There was a problem hiding this comment.
Something should be added here about code reorganization.
|
Hey Nik, can you rebase this against the latest |
nik-aleliunas
force-pushed
the
making-namespace-package
branch
from
fe6b72b to
c251a2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of this is about adding pkgutils to the init files, but I aslo moved the code into a src/ directory for better organization.