-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: reimplement live2d story reader #529
Conversation
Thank you for this PR! It looks pretty good and works well. I did some simple tests and found some points to improve:
const identifer = soundData.Se;
const isEventSe = soundData.Se.startsWith("se_event");
const baseDir = isEventSe
? `event_story/${soundData.Se.split("_").slice(1, -1).join("_")}`
: "sound/scenario/se";
const seBundleName = soundData.Se.startsWith("se_event")
? "scenario_se"
: soundData.Se.endsWith("_b")
? "se_pack00001_b"
: "se_pack00001";
const url = `${baseDir}/${seBundleName}_rip/${soundData.Se}.mp3`;
I'd like to merge it for an alpha version if you can fix some of them, especially the first one. |
|
The majority of the effects have been implemented! Ready to be merged, and please review! |
@dnaroma is currently unable to review at this time. He may be pursuing on other project. And i can't review yours as well. |
Thanks, I will review it ASAP, probably after new year :) |
Still waiting... |
It looks good, but has still some small bugs. I will merge it and fix it myself. |
This issue is now merged, but the live2d option is greyed out. EDIT: nvm, it is no longer greyed out thanks to 1.14.0 update |
Description
Totally re-implemented live2d story reader for current version of sekai.best.
Related Issue
#369
Motivation and Context
I NEED MORE CARD STORIES FOR MAFUYU!!!
How Has This Been Tested?
Screenshots (if appropriate):
features
TODO (not mecessary for current version)