fix(score): multiroom player skill calculation #528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
getMultiSkillRate
form calculating "scale factor" to calculating "rate of change".Related Issue
#403
#404
Motivation and Context
The scores in the multiplayer mode calculated by the "Song Recommender" website differ from those shown of the game.
The
getMultiSkillRate
function previously implemented the formula for "effective skill powers" based on the game's mechanics before the official change. The previous implementation:sekai-viewer/src/utils/scoreCalc.ts
Lines 56 to 62 in 4301ecc
The old formula was:
which represents a "rate of change".
The implementation in
src/utils/scoreCalc.ts
is based on representing an "effective skill power" as a "rate of change" .Therefore, the updated formula should also represent a "rate of change," which is:
$\mathtt{skill}_1 + \frac{\mathtt{skill}_2}{5} + \frac{\mathtt{skill}_3}{5} + \frac{\mathtt{skill}_4}{5} + \frac{\mathtt{skill}_5}{5}$ .
How Has This Been Tested?
Screenshots (if appropriate):