From 9c0f02400171464c6d303600e93b220cc7f75318 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ina=20Od=C3=A9n=20=C3=96sterbo?= Date: Tue, 4 Mar 2025 16:11:20 +0100 Subject: [PATCH 01/39] log file required unless force-no-log --- dds_cli/__main__.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/dds_cli/__main__.py b/dds_cli/__main__.py index 6ed3d471e..c0cf5dd5d 100644 --- a/dds_cli/__main__.py +++ b/dds_cli/__main__.py @@ -39,6 +39,7 @@ import dds_cli.user import dds_cli.utils from dds_cli.options import ( + NotRequiredIf, destination_option, email_arg, email_option, @@ -107,7 +108,8 @@ @click.option( "-v", "--verbose", is_flag=True, default=False, help="Print verbose output to the console." ) -@click.option("-l", "--log-file", help="Save a log to a file.", metavar="") +@click.option("--force-no-log", help="[NOT RECOMMENDED] Do not save logs to a file.", is_flag=True) +@click.option("-l", "--log-file", help="Save a log to a file.", metavar="", required=not bool("--force-no-log" in sys.argv)) @click.option( "--no-prompt", is_flag=True, default=False, help="Run without any interactive features." ) @@ -121,7 +123,7 @@ help="List the options of any DDS subcommand and its default settings.", ) @click.pass_context -def dds_main(click_ctx, verbose, log_file, no_prompt, token_path): +def dds_main(click_ctx, verbose, force_no_log, log_file, no_prompt, token_path): """SciLifeLab Data Delivery System (DDS) command line interface. Access token is saved in a .dds_cli_token file in the home directory. @@ -165,6 +167,7 @@ def dds_main(click_ctx, verbose, log_file, no_prompt, token_path): ) LOG.addHandler(log_fh) + sys.exit() # Create context object click_ctx.obj = {"NO_PROMPT": no_prompt, "TOKEN_PATH": token_path} From 8980d25341a0bf34f43364911fcc289d5af65d43 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ina=20Od=C3=A9n=20=C3=96sterbo?= Date: Tue, 4 Mar 2025 16:12:10 +0100 Subject: [PATCH 02/39] remove sys exit --- dds_cli/__main__.py | 1 - 1 file changed, 1 deletion(-) diff --git a/dds_cli/__main__.py b/dds_cli/__main__.py index c0cf5dd5d..9b0a43abd 100644 --- a/dds_cli/__main__.py +++ b/dds_cli/__main__.py @@ -167,7 +167,6 @@ def dds_main(click_ctx, verbose, force_no_log, log_file, no_prompt, token_path): ) LOG.addHandler(log_fh) - sys.exit() # Create context object click_ctx.obj = {"NO_PROMPT": no_prompt, "TOKEN_PATH": token_path} From 828dd8a2a5e73f30a57e70646bd991964ccc04cb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ina=20Od=C3=A9n=20=C3=96sterbo?= Date: Tue, 4 Mar 2025 16:57:47 +0100 Subject: [PATCH 03/39] Update help info to option --- dds_cli/__main__.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dds_cli/__main__.py b/dds_cli/__main__.py index 9b0a43abd..592aa1afc 100644 --- a/dds_cli/__main__.py +++ b/dds_cli/__main__.py @@ -39,7 +39,6 @@ import dds_cli.user import dds_cli.utils from dds_cli.options import ( - NotRequiredIf, destination_option, email_arg, email_option, @@ -109,7 +108,7 @@ "-v", "--verbose", is_flag=True, default=False, help="Print verbose output to the console." ) @click.option("--force-no-log", help="[NOT RECOMMENDED] Do not save logs to a file.", is_flag=True) -@click.option("-l", "--log-file", help="Save a log to a file.", metavar="", required=not bool("--force-no-log" in sys.argv)) +@click.option("-l", "--log-file", help="Save logs to file. In the case of opening a support ticket regarding the DDS, attach this file. We recommend naming it according to this format: _