-
Notifications
You must be signed in to change notification settings - Fork 29
feat: make frontend config and theme file locations configurable #1830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Will leave conflicts between master and this branch alone until some points are discussed. I'll transfer the most recent frontend.config.json to the new file once ready to merge.
|
@HayenNico I think that the changes is sensible, although I would move all the configuration files under a folder called It definitely impact existing deployment, unless they specify the relative env variables to the current location that they are using now. Maybe we should explicitly say that in the documentation. |
@nitrosx Okay, in that case how about this plan: |
Description
Add backend configuration options to customize the file locations of
frontend.config.json
andfrontend.theme.json
via new environment variablesFRONTEND_CONFIG_FILE
andFRONTEND_THEME_FILE
. The default location has been changed from /src/config to project root for consistency with other customizable configuration files (up for discussion).Motivation
The backend will serve a configuration and theme to a connected frontend via the
/api/v3/admin/config
and/api/v3/admin/theme
endpoints. The data sources for these endpoints are currently hardcoded to/src/config/frontend.config.json
and/src/config/frontend.config.json
. This is inconsistent with other configuration files which are located at the project root and can be configured in.env
.This PR introduces environment variables
FRONTEND_CONFIG_FILE
andFRONTEND_THEME_FILE
for customizing the location of the json files. The default location of both files has been moved to the project root directory.Changes:
FRONTEND_CONFIG_FILE
andFRONTEND_THEME_FILE
environment variablesfrontend.config.json
andfrontend.theme.json
from/src/config
to project root directoryTests included
Documentation
official documentation info