-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default REGEX_EXCLUDE footprint name filter excludes components whose footprint names contain "MountingHoles" #169
Comments
@phansel thanks for reporting. Would you be willing to submit a PR to fix this? |
I have a couple theories on how we could address this:
|
Looking at the current KiCad 6 library I see that real mounting holes starts its name with So I think that for KiCad 6 we just need to add a The same seems to be true for the KiCad 5.1.9 lib. |
- Applied to the Footprint - The ac39118 fix only affected the Part Related to SchrodingersGat/KiBoM#169 Fixes #201
This bit me again with a But I opted for something less subtle, removing the Also worth keeping in mind issue #178 , which has the same root cause. Any fix should probably be general enough to catch this family of issues, without making the out-of-the-box experience worse for most users. |
Default REGEX_EXCLUDE footprint name filter excludes some components whose footprint names contain "MountingHoles".
Per the default bom.ini, a component whose footprint field is "PROJ_LIB:DSUB-9_Female_Vertical_P2.77x2.84mm_MountingHoles" would be matched by the default filter (below) and silently excluded from the BOM.
The text was updated successfully, but these errors were encountered: