Fixed IBL sampled pdf term.

ScatteredRay · Jul 19, 2016 · 29202b2 · 29202b2
1 parent eaad9d6
commit 29202b2
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/shaders/montecarlo.glsl b/shaders/montecarlo.glsl
@@ -78,13 +78,15 @@ vec4 CosWeightedHemisphereTangentSpace(vec2 e)
     float r = sqrt(e.x);
     float th = 2.0 * PI * e.y;
 
-    float pdf = r / (2.0 * PI);
-
-    return vec4(
+    vec4 ret = vec4(
         r * cos(th),
         r * sin(th),
         sqrt(max(0.0, 1.0 - e.x)),
-        pdf);
+        0);
+
+    float pdf = ret.z / PI;
+    ret.w = pdf;
+    return ret;
 }
 
 

diff --git a/shaders/surface_frag.glsl b/shaders/surface_frag.glsl
@@ -141,9 +141,9 @@ void main()
         r += rand2(vScreenPos.xy);
         r = fract(r);
         vec4 d = CosWeightedHemisphere(r, nz, nx, ny);
-        float cosine = max(0.0, dot(d.xyz, nz)) / (2.0 * PI);
+        float cosine = max(0.0, dot(d.xyz, nz)) / (PI);
         float pdf = d.w;
-        vec3 l = max(BRDF(d.xyz, V, nz, nx, ny), vec3(0.0)) * pdf * 24.0;
+        vec3 l = max(BRDF(d.xyz, V, nz, nx, ny), vec3(0.0)) / pdf;
         color += l * textureCube(envMap, d.xyz).rgb / float(numSamples);
     }