Feature/streaming #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sauci
requested changes
Jan 28, 2025
pya2l/parser.py
Outdated
| @@ -110,12 +142,37 @@ def tree_from_json(self, json_data: bytes, allow_partial: bool = False) -> RootN | |||
| """ | |||
| if self._logger: | |||
| self._logger.info('start parsing JSON A2L') | |||
| response = self._client.GetTreeFromJSON(TreeFromJSONRequest(json=json_data, allow_partial=allow_partial)) | |||
|
|
|||
| # Générateur de requêtes : on envoie les options `allow_partial` dans le premier chunk. | |||
There was a problem hiding this comment.
Could you change the comments to english?
pya2l/parser.py
Outdated
|
|
||
| for response in self._client.GetTreeFromJSON(request_generator()): | ||
| if response.error: | ||
| if self._logger: |
There was a problem hiding this comment.
This could be changed into a single if statement and a and condition probably
| @pytest.mark.parametrize('module', [pytest.param(['COMPU_METHOD', 0, 'COEFFS_LINEAR'], id='COMPU_METHOD')], indirect=True) | ||
| @pytest.mark.parametrize('s', ['COEFFS_LINEAR {float} {float}']) | ||
| @pytest.mark.parametrize('float_string, float_value', floats) | ||
| def test_coeffs_linear(module, s, float_string, float_value): |
There was a problem hiding this comment.
I don't see any update of the shared libraries here, I think you have to merge the latest release in your branch.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #30 +/- ##
============================================
- Coverage 94.15% 70.13% -24.02%
============================================
Files 17 17
Lines 2496 2588 +92
============================================
- Hits 2350 1815 -535
- Misses 146 773 +627 ☔ View full report in Codecov by Sentry. |
Sauci
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.