Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Composite CV #17530

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Composite CV #17530

wants to merge 1 commit into from

Conversation

shweta83
Copy link
Contributor

@shweta83 shweta83 commented Feb 6, 2025 •
edited
Loading

Problem Statement

Composite CV test in settings is failing because it was using old contentview page

Solution

Update the test to use new contentview page and few other updates in it as per the new implementation of CV

Related Issues

SatelliteQE/airgun#1734

@shweta83 shweta83 added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Feb 6, 2025
@shweta83 shweta83 requested a review from a team as a code owner February 6, 2025 11:16
@shweta83
Copy link
Contributor Author

shweta83 commented Feb 6, 2025

trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py::test_positive_update_restrict_composite_view[restrict_composite_view]
airgun: 1734

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10094
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_settings.py::test_positive_update_restrict_composite_view[restrict_composite_view] --external-logging
Test Result : ================== 1 failed, 9 warnings in 595.02s (0:09:55) ===================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 6, 2025
@shweta83 shweta83 force-pushed the fix_composite_cv_setting_test branch from bae1196 to f27a169 Compare February 7, 2025 07:00
@shweta83 shweta83 mentioned this pull request Feb 7, 2025
Open
@shweta83
Copy link
Contributor Author

shweta83 commented Feb 7, 2025

trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py::test_positive_update_restrict_composite_view[restrict_composite_view]
airgun: 1734

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10116
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_settings.py::test_positive_update_restrict_composite_view[restrict_composite_view] --external-logging
Test Result : ================== 1 failed, 9 warnings in 603.16s (0:10:03) ===================

@vijaysawant
Copy link
Contributor

@shweta83 I think I know the issue why this build is failing with error

displayMessage":"Pending tasks detected in repositories of this content view. Please wait for the tasks: - https://ip-satellite.redhat.com/foreman_tasks/tasks/40a81f42-2595-4864-857d-d6428d22c068 before publishing.

You need to use wait_for_tasks where repo creates, please try using something like this #17171

vijaysawant
vijaysawant approved these changes Feb 7, 2025
View reviewed changes
Copy link
Contributor

@vijaysawant vijaysawant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, please try to fix PRT

@shweta83 shweta83 force-pushed the fix_composite_cv_setting_test branch from f27a169 to 230314c Compare February 7, 2025 10:07
@shweta83 shweta83 requested a review from a team as a code owner February 7, 2025 10:07
@shweta83
Copy link
Contributor Author

shweta83 commented Feb 7, 2025

@shweta83 I think I know the issue why this build is failing with error

displayMessage":"Pending tasks detected in repositories of this content view. Please wait for the tasks: - https://ip-satellite.redhat.com/foreman_tasks/tasks/40a81f42-2595-4864-857d-d6428d22c068 before publishing.

You need to use wait_for_tasks where repo creates, please try using something like this #17171

Thanks @vijaysawant ! Surprisingly this doesn't happen with local run.

@shweta83 shweta83 force-pushed the fix_composite_cv_setting_test branch from 230314c to d16d189 Compare February 7, 2025 10:11
@shweta83
Copy link
Contributor Author

shweta83 commented Feb 7, 2025

trigger: test-robottelo
pytest: tests/foreman/ui/test_settings.py::test_positive_update_restrict_composite_view[restrict_composite_view]
airgun: 1734

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10120
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_settings.py::test_positive_update_restrict_composite_view[restrict_composite_view] --external-logging
Test Result : ================== 1 failed, 15 warnings in 758.27s (0:12:38) ==================

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysawant vijaysawant vijaysawant approved these changes

Assignees

@shweta83 shweta83

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shweta83 @Satellite-QE @vijaysawant