Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NUI] Refine View extension methods #6672

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[NUI] Refine View extension methods #6672

merged 1 commit into from
Feb 18, 2025

Conversation

rabbitfor
Copy link
Collaborator

Description of Change

  • Provide BoxShadow getter
  • UIColor getter returns token value properly
    • Color
    • BackgroundColor
    • BoxShadow
    • BorderlineColor
  • Size and Position receives UIVector3 instead of UIVector2
    • Provide implicit convertion from UIVector2 to UIVector3

API Changes

  • ACR:

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 26, Removed: 6, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.ITokenTable`1::TryGetToken(Tizen.NUI.BaseComponents.View,System.String,Tizen.NUI.IToken`1<T>&)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.UIShadow::IsDefault()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.UIShadow Tizen.NUI.UIShadow::Default()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.UIVector3

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIVector3 Tizen.NUI.UIVector3::Zero

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.UIVector3::IsZero()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Depth()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Height()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Width()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::X()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Y()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Z()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.UIVector3::Equals(System.Object)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.UIVector3::Equals(Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.UIVector3::op_Equality(Tizen.NUI.UIVector3,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.UIVector3::op_Inequality(Tizen.NUI.UIVector3,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.NUI.UIVector3::GetHashCode()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.UIVector3::.ctor(System.Single,System.Single,System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.UIVector3::.ctor(System.Single,System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIVector3 Tizen.NUI.UIVector3::op_Addition(Tizen.NUI.UIVector3,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIVector3 Tizen.NUI.UIVector3::op_Implicit(Tizen.NUI.UIVector2)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIVector3 Tizen.NUI.UIVector3::op_Subtraction(Tizen.NUI.UIVector3,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Vector3 Tizen.NUI.UIVector3::op_Implicit(Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static T Tizen.NUI.Extension.ViewExtensions::Position(T,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static T Tizen.NUI.Extension.ViewExtensions::Size(T,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIShadow Tizen.NUI.Extension.ViewExtensions::BoxShadow(Tizen.NUI.BaseComponents.View)

Removed

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.IToken`1::Apply(TView,Tizen.NUI.IPropertySetter`1<T>)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.UIColor::Apply(T,Tizen.NUI.IPropertySetter`1<Tizen.NUI.UIColor>)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static T Tizen.NUI.Extension.ViewExtensions::Position(T,Tizen.NUI.UIVector2)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static T Tizen.NUI.Extension.ViewExtensions::Size(T,Tizen.NUI.UIVector2)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.UIVector2 Tizen.NUI.Extension.ViewExtensions::Position(Tizen.NUI.BaseComponents.View)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.UIVector2 Tizen.NUI.Extension.ViewExtensions::Size(Tizen.NUI.BaseComponents.View)

dongsug-song
dongsug-song approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@rabbitfor
[NUI] Refine View extension methods
c130c3b 
* Provide BoxShadow getter
* UIColor getter returns token value properly
  * Color
  * BackgroundColor
  * BoxShadow
  * BorderlineColor
* Size and Position receives UIVector3 instead of UIVector2
  * Provide implicit convertion from UIVector2 to UIVector3

Signed-off-by: Jiyun Yang <ji.yang@samsung.com>
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 24, Removed: 6, Changed: 0

Added

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.ITokenTable`1::TryGetToken(Tizen.NUI.BaseComponents.View,System.String,Tizen.NUI.IToken`1<T>&)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.UIShadow::IsDefault()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.UIShadow Tizen.NUI.UIShadow::Default()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ Tizen.NUI.UIVector3

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIVector3 Tizen.NUI.UIVector3::Zero

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.UIVector3::IsZero()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Depth()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Height()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Width()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::X()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Y()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Single Tizen.NUI.UIVector3::Z()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.UIVector3::Equals(System.Object)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.NUI.UIVector3::Equals(Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.UIVector3::op_Equality(Tizen.NUI.UIVector3,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static System.Boolean Tizen.NUI.UIVector3::op_Inequality(Tizen.NUI.UIVector3,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Int32 Tizen.NUI.UIVector3::GetHashCode()

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.UIVector3::.ctor(System.Single,System.Single,System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Void Tizen.NUI.UIVector3::.ctor(System.Single,System.Single)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIVector3 Tizen.NUI.UIVector3::op_Addition(Tizen.NUI.UIVector3,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIVector3 Tizen.NUI.UIVector3::op_Implicit(Tizen.NUI.UIVector2)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIVector3 Tizen.NUI.UIVector3::op_Subtraction(Tizen.NUI.UIVector3,Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.Vector3 Tizen.NUI.UIVector3::op_Implicit(Tizen.NUI.UIVector3)

+ /// <since_tizen>none</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ static Tizen.NUI.UIShadow Tizen.NUI.Extension.ViewExtensions::BoxShadow(Tizen.NUI.BaseComponents.View)

Removed

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.IToken`1::Apply(TView,Tizen.NUI.IPropertySetter`1<T>)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.UIColor::Apply(T,Tizen.NUI.IPropertySetter`1<Tizen.NUI.UIColor>)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static T Tizen.NUI.Extension.ViewExtensions::Position(T,Tizen.NUI.UIVector2)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static T Tizen.NUI.Extension.ViewExtensions::Size(T,Tizen.NUI.UIVector2)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.UIVector2 Tizen.NUI.Extension.ViewExtensions::Position(Tizen.NUI.BaseComponents.View)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.UIVector2 Tizen.NUI.Extension.ViewExtensions::Size(Tizen.NUI.BaseComponents.View)

everLEEst
everLEEst approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@everLEEst everLEEst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rabbitfor rabbitfor merged commit e512579 into Samsung:DevelNUI Feb 18, 2025
3 checks passed
@rabbitfor rabbitfor deleted the tokengetter branch February 18, 2025 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everLEEst everLEEst everLEEst approved these changes

@dongsug-song dongsug-song dongsug-song approved these changes

@Seoyeon2Kim Seoyeon2Kim Awaiting requested review from Seoyeon2Kim Seoyeon2Kim is a code owner

@taehyub taehyub Awaiting requested review from taehyub taehyub is a code owner

@jaehyun0cho jaehyun0cho Awaiting requested review from jaehyun0cho jaehyun0cho is a code owner

Assignees
No one assigned
Labels
Devel-NUI Internal API Changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rabbitfor @TizenAPI-Bot @everLEEst @dongsug-song