Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PackageManager] add IsUpdated property to Package Class #6669

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kdk3776
Copy link

@kdk3776 kdk3776 commented Feb 17, 2025

Description of Change

  • add IsUpdated function which can tell certain packages are update or not.

@kdk3776 kdk3776 requested a review from jeremy-jang as a code owner February 17, 2025 14:29
@github-actions github-actions bot added the API13 label Feb 17, 2025
@kdk3776 kdk3776 changed the title add update [PackageManager] add Isupdated Feb 17, 2025
@kdk3776 kdk3776 force-pushed the main branch 2 times, most recently from ba2a9b1 to 5c753bf Compare February 17, 2025 23:31
@hjhun hjhun changed the title [PackageManager] add Isupdated [PackageManager] add IsUpdated property to Package Class Feb 17, 2025
/// <summary>
/// Checks whether the package is updated.
/// </summary>
/// <since_tizen> 3 </since_tizen>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[EditorBrowsable(EditorBrowsableState.Never)]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to 12.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -364,6 +372,11 @@ internal static Package CreatePackage(IntPtr handle, string pkgId)
{
Log.Warn(LogTag, "Failed to get whether package " + pkgId + " is preloaded or not");
}
Copy link
Contributor

@hjhun hjhun Feb 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The return value should be set to the err as below:

err = Interop.Package.PackageInfoIsUpdatePackage(handle, out package._isUpdated);

@TizenAPI-Bot
Copy link
Collaborator

Build Error:

src/Tizen.Applications.PackageManager/Tizen.Applications/Package.cs(133,10): error CS0246: The type or namespace name 'EditorBrowsableAttribute' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Applications.PackageManager/Tizen.Applications.PackageManager.csproj]
src/Tizen.Applications.PackageManager/Tizen.Applications/Package.cs(133,10): error CS0246: The type or namespace name 'EditorBrowsable' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Applications.PackageManager/Tizen.Applications.PackageManager.csproj]
src/Tizen.Applications.PackageManager/Tizen.Applications/Package.cs(133,26): error CS0103: The name 'EditorBrowsableState' does not exist in the current context [src/Tizen.Applications.PackageManager/Tizen.Applications.PackageManager.csproj]

@hjhun
Copy link
Contributor

hjhun commented Feb 17, 2025

Build Error:

src/Tizen.Applications.PackageManager/Tizen.Applications/Package.cs(133,10): error CS0246: The type or namespace name 'EditorBrowsableAttribute' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Applications.PackageManager/Tizen.Applications.PackageManager.csproj]
src/Tizen.Applications.PackageManager/Tizen.Applications/Package.cs(133,10): error CS0246: The type or namespace name 'EditorBrowsable' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Applications.PackageManager/Tizen.Applications.PackageManager.csproj]
src/Tizen.Applications.PackageManager/Tizen.Applications/Package.cs(133,26): error CS0103: The name 'EditorBrowsableState' does not exist in the current context [src/Tizen.Applications.PackageManager/Tizen.Applications.PackageManager.csproj]

@kdk3776 , please check this build error.
You missed to add "using System.ComponentModel;".

@TizenAPI-Bot
Copy link
Collaborator

Build Error:

src/Tizen.Applications.PackageManager/Tizen.Applications/Package.cs(133,10): error CS0246: The type or namespace name 'EditorBrowsableAttribute' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Applications.PackageManager/Tizen.Applications.PackageManager.csproj]
src/Tizen.Applications.PackageManager/Tizen.Applications/Package.cs(133,10): error CS0246: The type or namespace name 'EditorBrowsable' could not be found (are you missing a using directive or an assembly reference?) [src/Tizen.Applications.PackageManager/Tizen.Applications.PackageManager.csproj]
src/Tizen.Applications.PackageManager/Tizen.Applications/Package.cs(133,26): error CS0103: The name 'EditorBrowsableState' does not exist in the current context [src/Tizen.Applications.PackageManager/Tizen.Applications.PackageManager.csproj]

Signed-off-by: Sangyoon Jang <jeremy.jang@samsung.com>
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 1, Removed: 0, Changed: 0

Added

+ /// <since_tizen>12</since_tizen
+ [EditorBrowsable(EditorBrowsableState.Never)]
+ System.Boolean Tizen.Applications.Package::IsUpdated()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants