Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NUI] Support to view constructor which we can ignore Relayout #6664

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

hinohie
Copy link
Contributor

@hinohie hinohie commented Feb 13, 2025

Let we make view creation method that we can ignore DALi engine side Relayout feature.

It will be useful when we can assume that

  • This view always be exist under Layout
  • ResizePolicy don't need
  • Relayout event not required
  • Internal visuals, or VisualObjects don't use FittingMode.
  • Text are not be used

Relative dali patch :

https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/319564

@TizenAPI-Bot
Copy link
Collaborator

Build Error:

src/Tizen.NUI/src/public/BaseComponents/View.cs(545,88): error CS0103: The name 'ResizePolicyMode' does not exist in the current context [src/Tizen.NUI/Tizen.NUI.csproj]

@hinohie hinohie force-pushed the new_view_without_size_negotiate branch from 5fe20f9 to 1daaa40 Compare February 13, 2025 05:24
@TizenAPI-Bot
Copy link
Collaborator

Build Error:

src/Tizen.NUI/src/public/BaseComponents/View.cs(545,88): error CS0103: The name 'ResizePolicyMode' does not exist in the current context [src/Tizen.NUI/Tizen.NUI.csproj]

@hinohie hinohie force-pushed the new_view_without_size_negotiate branch 2 times, most recently from 6f26214 to 155486d Compare February 13, 2025 10:24
@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 0, Removed: 4, Changed: 0

Removed

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.BaseComponents.View::.ctor(Tizen.NUI.BaseComponents.View/ViewAccessibilityMode)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View/ViewAccessibilityMode

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.BaseComponents.View/ViewAccessibilityMode Tizen.NUI.BaseComponents.View/ViewAccessibilityMode::Custom

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.BaseComponents.View/ViewAccessibilityMode Tizen.NUI.BaseComponents.View/ViewAccessibilityMode::Default

@TizenAPI-Bot
Copy link
Collaborator

Internal API Changed

Added: 0, Removed: 4, Changed: 0

Removed

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.BaseComponents.View::.ctor(Tizen.NUI.BaseComponents.View/ViewAccessibilityMode)

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View/ViewAccessibilityMode

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.BaseComponents.View/ViewAccessibilityMode Tizen.NUI.BaseComponents.View/ViewAccessibilityMode::Custom

- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.BaseComponents.View/ViewAccessibilityMode Tizen.NUI.BaseComponents.View/ViewAccessibilityMode::Default

Let we make view creation method that we can ignore
DALi engine side Relayout feature.

It will be useful when we can assume that
 - This view always be exist under Layout
 - ResizePolicy don't need
 - Relayout event not required
 - Internal visuals, or VisualObjects don't use FittingMode.
 - Text are not be used

Relative dali patch :

https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/319564

Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
@hinohie hinohie force-pushed the new_view_without_size_negotiate branch from b4287b9 to de4d365 Compare February 18, 2025 03:25
Copy link
Contributor

@taehyub taehyub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dongsug-song dongsug-song left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@hinohie hinohie merged commit f65a62e into Samsung:DevelNUI Feb 18, 2025
3 checks passed
@hinohie hinohie deleted the new_view_without_size_negotiate branch February 18, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants