-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NUI] Support to view constructor which we can ignore Relayout #6664
Merged
hinohie
merged 1 commit into
Samsung:DevelNUI
from
hinohie:new_view_without_size_negotiate
Feb 18, 2025
Merged
[NUI] Support to view constructor which we can ignore Relayout #6664
hinohie
merged 1 commit into
Samsung:DevelNUI
from
hinohie:new_view_without_size_negotiate
Feb 18, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Error:
|
bshsqa
reviewed
Feb 13, 2025
5fe20f9
to
1daaa40
Compare
Build Error:
|
rabbitfor
reviewed
Feb 13, 2025
6f26214
to
155486d
Compare
Internal API ChangedAdded: 0, Removed: 4, Changed: 0Removed- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.BaseComponents.View::.ctor(Tizen.NUI.BaseComponents.View/ViewAccessibilityMode)
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View/ViewAccessibilityMode
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.BaseComponents.View/ViewAccessibilityMode Tizen.NUI.BaseComponents.View/ViewAccessibilityMode::Custom
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.BaseComponents.View/ViewAccessibilityMode Tizen.NUI.BaseComponents.View/ViewAccessibilityMode::Default
|
155486d
to
b4287b9
Compare
Internal API ChangedAdded: 0, Removed: 4, Changed: 0Removed- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- System.Void Tizen.NUI.BaseComponents.View::.ctor(Tizen.NUI.BaseComponents.View/ViewAccessibilityMode)
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- Tizen.NUI.BaseComponents.View/ViewAccessibilityMode
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.BaseComponents.View/ViewAccessibilityMode Tizen.NUI.BaseComponents.View/ViewAccessibilityMode::Custom
- /// <since_tizen>none</since_tizen
- [EditorBrowsable(EditorBrowsableState.Never)]
- static Tizen.NUI.BaseComponents.View/ViewAccessibilityMode Tizen.NUI.BaseComponents.View/ViewAccessibilityMode::Default
|
Let we make view creation method that we can ignore DALi engine side Relayout feature. It will be useful when we can assume that - This view always be exist under Layout - ResizePolicy don't need - Relayout event not required - Internal visuals, or VisualObjects don't use FittingMode. - Text are not be used Relative dali patch : https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/319564 Signed-off-by: Eunki, Hong <eunkiki.hong@samsung.com>
b4287b9
to
de4d365
Compare
rabbitfor
approved these changes
Feb 18, 2025
taehyub
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dongsug-song
approved these changes
Feb 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let we make view creation method that we can ignore DALi engine side Relayout feature.
It will be useful when we can assume that
Relative dali patch :
https://review.tizen.org/gerrit/c/platform/core/uifw/dali-csharp-binder/+/319564