[NUI] Fix a crash when applying ViewStyle. #6661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huayongxu
requested review from
dongsug-song,
Seoyeon2Kim,
taehyub,
jaehyun0cho,
everLEEst and
rabbitfor
as code owners
|
After Xaml in ViewStyle is disabled, Selector instance is returned when ViewStyle.GetInternalBackgroundColorProperty But in View.SetInternalBackgroundColorProperty, NUIApplication.IsUsingXaml is checked, then this will cause cast exception. The NUIApplication.IsUsingXaml check is added in the patch #6077 . |
everLEEst
approved these changes
Feb 12, 2025
huayongxu
force-pushed
the
fix-crash-1
branch
from
72ff026 to
315b497
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
API Changes