-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admin page for viewing all positions in a recruitment #1615
Draft
Snorre98
wants to merge
42
commits into
master
Choose a base branch
from
1606-add-new-recruitmentpositionoverviewpage-for-all-positions-in-a-recrutiment
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Admin page for viewing all positions in a recruitment #1615
Snorre98
wants to merge
42
commits into
master
from
1606-add-new-recruitmentpositionoverviewpage-for-all-positions-in-a-recrutiment
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge-for-all-positions-in-a-recrutiment
Snorre98
commented
Feb 2, 2025
frontend/src/PagesAdmin/RecruitmentAllPositionsAdminPage/RecruitmentAllPositionsAdminPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/PagesAdmin/RecruitmentAllPositionsAdminPage/RecruitmentAllPositionsAdminPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/PagesAdmin/RecruitmentAllPositionsAdminPage/RecruitmentAllPositionsAdminPage.tsx
Outdated
Show resolved
Hide resolved
frontend/src/PagesAdmin/RecruitmentAllPositionsAdminPage/RecruitmentAllPositionsAdminPage.tsx
Outdated
Show resolved
Hide resolved
...nd/src/PagesAdmin/RecruitmentGangOverviewPage/components/AppletContainer/AppletContainer.tsx
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This page is usefull for managing all applicants. This is something UKA and ISFiT cant live without, but I focused on making it usefull for Samfundet overordnet opptaksansvarlig in the first place.
The "Tillat å kontakte" feature might have to be implemented in another way (it does not have functionality now), but the plan is that "overordnet opptaksansvarlig" can manage who the gang is allowed to call. I have not yet decided how this should work, but if we go for the simple "switch" interface it might be smart to have the applications which are not in conflict (in regards to where the applicant will end up) set to "Tillat å kontakte"=true by default.
This could be processed after the "gang priority deadline", so that "overordnet opptaksansvarlig" does not have to administrate all applicants.
The idea is that the "Tillat å kontakte" state automatically tells "gjeng opptaksansvarlig" on the "all applications" page of the gang that some applicant can be contacted. "gjeng opptaksansvarlig" then communicates to sections who to call.
Take a look at the figma sketches here: https://www.figma.com/design/Pn74DlI9e5YO3tjhehp4nU/Behandle-alle?node-id=0-1&t=RWn8SfUicqJyhlnW-1
There is alot that has to be done before this can be completed, so this is just a PR for creating a starting point.
Before mergin I will create issues for this:
the helper functions / sorting algo can probably be improved or moved to backend
organize application data in backend to be oriented towards the user which owns the applications (in this PR it is being done in frontend)
add ability to set interview for multiple applications at once
- frontend on SetInterviewsManuallyModal + api call function
- backend to handle setting interviews for multiple positions
ability to sort applicants on similar position application combination
ability to filter applicants on a set of positions (with multi select?)
ability to filter by gang
ability to filter by section
ability to filter by conflict/not conflict (application state)
(not needed just yet) set interviews for all applicants
For Samf
For UKA/ISFiT/KSG: