Merge pull request #446 from SalesforceLabs/445-recompilation-of-apexclass-button-may-not-work

fix: symboltable is null when it should not Recompilation of ApexClas…

Author: VinceFINET

force-app/main/default/lwc/orgcheckApp/api/core/orgcheck-api-sfconnectionmanager.js

@@ -20,6 +20,7 @@ export class DailyApiRequestLimitInformation {
 }
 
 const MAX_COMPOSITE_REQUEST_SIZE = 25;
+const MAX_NOQUERYMORE_BATCH_SIZE = 200;
 const DAILY_API_REQUEST_WARNING_THRESHOLD = 0.70; // =70%
 const DAILY_API_REQUEST_FATAL_THRESHOLD = 0.90;   // =90%
 
@@ -277,7 +278,7 @@ export class OrgCheckSalesforceManager {
             const conn = query.tooling === true ? this.#connection.tooling : this.#connection;
             const sequential_query = (callback) => {
                 if (query.queryMore === false) {
-                    conn.query(`${query.string} LIMIT 2000 OFFSET ${nbQueryMore * 2000}`, { autoFetch: false }, callback);
+                    conn.query(`${query.string} LIMIT ${MAX_NOQUERYMORE_BATCH_SIZE} OFFSET ${nbQueryMore * MAX_NOQUERYMORE_BATCH_SIZE}`, { autoFetch: false }, callback);
                 } else {
                     conn.query(query.string, { autoFetch: true }, callback);
                 }
@@ -300,7 +301,7 @@ export class OrgCheckSalesforceManager {
                         records.push(... d.records);
                         if (query.queryMore === false) {
                             // Here we can't call queryMore (the sobject in the FROM statment does not support it, like EntityDefinition)
-                            if (d.records.length < 2000) {
+                            if (d.records.length < MAX_NOQUERYMORE_BATCH_SIZE) {
                                 nbQueriesDone++;
                                 nbQueriesPending--;
                                 resolve({ records: records });

force-app/main/default/lwc/orgcheckApp/api/dataset/orgcheck-api-dataset-apexclasses.js

@@ -20,7 +20,8 @@ export class OrgCheckDatasetApexClasses extends OrgCheckDataset {
                         'CreatedDate, LastModifiedDate '+
                     'FROM ApexClass '+
                     'WHERE ManageableState IN (\'installedEditable\', \'unmanaged\') ',
-            tooling: true
+            tooling: true,
+            queryMore: false
         }, {
             string: 'SELECT ApexClassOrTriggerId, ApexTestClassId '+
                     'FROM ApexCodeCoverage',

force-app/main/default/lwc/orgcheckApp/orgcheckApp.js

@@ -205,10 +205,16 @@ export default class OrgCheckApp extends LightningElement {
             if (cr.body.success === true) {
                 this.#spinner.sectionEnded(`request-to-recompile-${c.id}`, `Recompilation requested for class: ${c.name}`);
             } else {
-                this.#spinner.sectionFailed(`request-to-recompile-${c.id}`, `Errors for class ${c.name}: ${cr.errors.map(e => JSON.stringify(e)).join(', ')}`);
+                let reasons = [];
+                if (cr.body && Array.isArray(cr.body)) {
+                    reasons = cr.body;
+                } else if (cr.errors && Array.isArray(cr.errors)) {
+                    reasons = cr.errors;
+                }
+                this.#spinner.sectionFailed(`request-to-recompile-${c.id}`, `Errors for class ${c.name}: ${reasons.map(e => JSON.stringify(e)).join(', ')}`);
             }
         }));
-        this.#spinner.sectionEnded('request-to-recompile', 'In case you need to recompile ALL the classes, go to "Setup > Custom Code > Apex Classes" and click on the link "Compile all classes".');
+        this.#spinner.sectionEnded('request-to-recompile', 'Please hit the Refresh button (in Org Check) to get the latest data from your Org.  By the way, in the future, if you need to recompile ALL the classes, go to "Setup > Custom Code > Apex Classes" and click on the link "Compile all classes".');
         this.#spinner.canBeClosed();
     }