-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@W-17405592 - DataCloud Events in PWA #2229
Open
carson-campbell
wants to merge
16
commits into
feature/datacloud-events
Choose a base branch
from
W-17405592.IntialDatacloudEvent
base: feature/datacloud-events
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
@W-17405592 - DataCloud Events in PWA #2229
carson-campbell
wants to merge
16
commits into
feature/datacloud-events
from
W-17405592.IntialDatacloudEvent
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SalesforceCommerceCloud/pwa-kit into W-17405592.IntialDatacloudEvent
carson-campbell
requested review from
bendvc,
yunakim714,
hajinsuha1 and
jeremy-jung1
January 30, 2025 21:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial DataCloud events implementation - to be followed by @yunakim714 unit and E2E testing, and documentation. Sends 5 types of events:
Types of Changes
Changes
How to Test-Drive This PR
npm run test app/hooks/use-datacloud.test.js
to check all unit tests are passing for all 5 eventsChecklists
General
Accessibility Compliance
You must check off all items in one of the follow two lists:
or...
Localization