Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store locator extension integration @@W-17273365@@ #2225

Merged
merged 17 commits into from
Jan 30, 2025
Merged

Store locator extension integration @@W-17273365@@ #2225

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
65791ae
conditionally render store-locator icon
kevinxh Jan 28, 2025
3a96e2d
hook up actions
kevinxh Jan 28, 2025
74d1742
fix errors by using the correct config
kevinxh Jan 28, 2025
27e9961
fix issues
kevinxh Jan 28, 2025
238cc2a
lint
kevinxh Jan 28, 2025
9c41ef6
lint
kevinxh Jan 28, 2025
f55faee
add tests
kevinxh Jan 28, 2025
8e43dfc
add tests
kevinxh Jan 28, 2025
1f5ddef
lint
kevinxh Jan 28, 2025
69566ed
fix test
kevinxh Jan 28, 2025
f7b38e9
pr feedback
kevinxh Jan 28, 2025
630500c
address feedback, fix dependencies
kevinxh Jan 28, 2025
47af3b0
minor fix
kevinxh Jan 28, 2025
399a4c4
remove test config and address pr feedback
kevinxh Jan 30, 2025
74caa00
remove unnecessary packages
kevinxh Jan 30, 2025
364be22
Update packages/extension-chakra-storefront/src/components/header/ind…
kevinxh Jan 30, 2025
71aa681
lint
kevinxh Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/extension-chakra-store-locator/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,8 @@
"prop-types": "^15",
"react": "^18",
"react-dom": "^18",
"react-router-dom": "^5.3.4"
"react-router-dom": "^5.3.4",
"react-hook-form": "^7"
},
"peerDependenciesMeta": {
"@chakra-ui/react": {
Expand All @@ -53,6 +54,9 @@
},
"react-dom": {
"optional": true
},
"react-hook-form": {
"optional": true
}
},
"devDependencies": {
Expand Down
8 changes: 7 additions & 1 deletion packages/extension-chakra-storefront/src/components/header/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,13 @@ const Header = ({
{...styles.icons}
variant="unstyled"
onClick={() => {
openModal()
if (
!window.location.pathname.includes(
storeLocatorExtension.config.path
)
Copy link
Collaborator

@alexvuong alexvuong Jan 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would it throw if storeLocatorExtension is undefined?
p/s nvm. Saw the conditional rendering above.

) {
openModal()
}
kevinxh marked this conversation as resolved.
Show resolved Hide resolved
}}
/>
)}
Expand Down
Loading