From 9dc5fb1addab0d23774df597995de98f2f35f0d5 Mon Sep 17 00:00:00 2001 From: Ben Chypak Date: Mon, 13 Jan 2025 11:20:04 -0800 Subject: [PATCH 1/2] Fix performance class rounding --- packages/pwa-kit-react-sdk/src/utils/performance.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/pwa-kit-react-sdk/src/utils/performance.js b/packages/pwa-kit-react-sdk/src/utils/performance.js index 811d7609a5..69a61366fa 100644 --- a/packages/pwa-kit-react-sdk/src/utils/performance.js +++ b/packages/pwa-kit-react-sdk/src/utils/performance.js @@ -53,7 +53,7 @@ export default class PerformanceTimer { buildServerTimingHeader() { const header = this.metrics .map((metric) => { - return `${metric.name};dur=${metric.duration}` + return `${metric.name};dur=${metric.duration.toFixed(2)}` }) .join(', ') @@ -117,7 +117,7 @@ export default class PerformanceTimer { if (startMark) { const measurement = { name, - duration: (timestamp - startMark.timestamp).toFixed(2), + duration: timestamp - startMark.timestamp, detail: options.detail } this.metrics.push(measurement) From 1de2abd5ff88e6cb762d0a84fe0e98ccf023dc0d Mon Sep 17 00:00:00 2001 From: Ben Chypak Date: Mon, 13 Jan 2025 11:22:43 -0800 Subject: [PATCH 2/2] Update CHANGELOG.md --- packages/pwa-kit-react-sdk/CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/pwa-kit-react-sdk/CHANGELOG.md b/packages/pwa-kit-react-sdk/CHANGELOG.md index 82a3634504..edd353a41d 100644 --- a/packages/pwa-kit-react-sdk/CHANGELOG.md +++ b/packages/pwa-kit-react-sdk/CHANGELOG.md @@ -1,4 +1,5 @@ ## v3.9.0-dev (Oct 29, 2024) +- Fix the performance logging util to not round duration. [#2199](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2199) - Add RedirectWithStatus component, allowing finer grained control of rediriects and their status code [#2173](https://github.com/SalesforceCommerceCloud/pwa-kit/pull/2173) ## v3.8.0 (Oct 28, 2024)