Updated node removals docs for clarity and correctness, overuse warning #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are there docs describing the options?
…On Fri, Nov 8, 2024, 15:58 Shawn Rushefsky ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In products/sgs/node-removals.mdx
<#106 (comment)>
:
> </Note>
-## Example Request
+## Example request
+
+```Curl.sh
I think this should just be "shell" or "bash" to get the right highlighting
—
Reply to this email directly, view it on GitHub
<#106 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATAG2PGFCOSRK5RRU6ONEHLZ7TGTBAVCNFSM6AAAAABRNHQZI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIMRUGAZTAMZSGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
@shawnrushefsky addressed your comment above. List of languages supported is visible here for future reference. |
shawnrushefsky
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several outdated items in the Node Removal guidelines. Fixed those, and hopefully made the section more clear - trying to make the node removal API more usable while discouraging overuse.