Merge pull request #1 from Sage/ruby-3-2-support

Update dependencies and test on Ruby 3.2

.github/dependabot.yml

@@ -1,13 +1,10 @@
 version: 2
+
 updates:
-- package-ecosystem: bundler
-  directory: "/"
-  schedule:
-    interval: daily
-    time: "08:00"
-  open-pull-requests-limit: 10
-  ignore:
-  - dependency-name: nokogiri
-    versions:
-    - 1.11.1
-    - 1.11.2
+  - package-ecosystem: bundler
+    directory: "/"
+    schedule:
+      interval: weekly
+    pull-request-branch-name:
+      separator: "-"
+    open-pull-requests-limit: 0

.github/workflows/config.yml

@@ -1,17 +1,50 @@
 name: Tests
-on:
-  push:
+
+on: [push]
 
 jobs:
-  rspec:
+  test:
     runs-on: ubuntu-latest
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: 2.7
+          ruby-version: 3.2
           bundler-cache: true
 
       - run: bundle exec rspec
+
+  release:
+    needs: test
+    if: startsWith(github.ref, 'refs/tags/v')
+    runs-on: ubuntu-latest
+
+    env:
+      GEMS_PATH: "pkg/*.gem"
+      RUBYGEMS_HOST: "https://sageonegems.jfrog.io/artifactory/api/gems/gems-local"
+      JFROG_USER: "${{ secrets.JFROG_USER }}"
+      JFROG_PASS: "${{ secrets.JFROG_PASS }}"
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.2'
+          bundler-cache: true
+
+      - name: Clear any existing packages
+        run: rm -f $GEMS_PATH
+
+      - name: Retrieve credentials
+        run: |
+          mkdir -p $HOME/.gem
+          curl -u $JFROG_USER:$JFROG_PASS $RUBYGEMS_HOST/api/v1/api_key.yaml > $HOME/.gem/credentials
+          chmod 600 $HOME/.gem/credentials
+      - name: Build gem
+        run: bundle exec rake build ofx.gemspec
+
+      - name: Publish
+        run: gem push $GEMS_PATH

.rubocop.yml

@@ -9,4 +9,4 @@
 #
 # See https://docs.rubocop.org/rubocop/configuration
 AllCops:
-  TargetRubyVersion: 2.7.5
+  TargetRubyVersion: 3.2

.ruby-version

@@ -0,0 +1 @@
+3.2.2

Gemfile

@@ -1,2 +1,7 @@
 source "https://rubygems.org"
+
 gemspec
+
+gem 'byebug', '>= 11.1.3'
+gem 'rake', '>= 13.0.6'
+gem 'rspec', '>= 3.10'

README.md

@@ -0,0 +1,69 @@
+# OFX
+
+[![Build Status](https://github.com/Sage/ofx/actions/workflows/config.yml/badge.svg)](https://github.com/Sage/ofx/actions)
+
+A simple OFX (Open Financial Exchange) parser built on top of Nokogiri. Currently supports both OFX 1.0.2 and 2.1.1.
+
+Works on both ruby 1.9 and 2.0.
+
+## Usage
+
+```ruby
+require "ofx"
+
+OFX("file.ofx") do
+  p account
+  p account.balance
+  p account.transactions
+end
+```
+
+Invalid files will raise an OFX::UnsupportedFileError.
+
+
+## Deploy
+
+1. Create and send the new version to Rubygems
+
+```ruby
+bundle exec rake release
+```
+
+2. Create a [new release on Github](https://github.com/annacruz/ofx/releases/new)
+
+* Choose **the new tag** (Ex.: v0.10.1)
+* Fill the **Release title** (Ex.: 0.10.1)
+* Click at **Generate release notes**
+* Click at **Publish release**
+
+3. Done!
+
+## Creator
+
+* Nando Vieira - http://simplesideias.com.br
+
+## Maintainer
+
+* Anna Cruz - http://anna-cruz.com
+
+## License
+
+(The MIT License)
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the 'Software'), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED 'AS IS', WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

lib/ofx/parser.rb

@@ -32,7 +32,7 @@ def open_resource(resource)
         if resource.respond_to?(:read)
           resource
         else
-          open(resource)
+          open(resource, encoding: 'UTF-8')
         end
       rescue
         StringIO.new(resource)

lib/ofx/version.rb

@@ -1,8 +1,8 @@
 module OFX
   module Version
-    MAJOR = 0
-    MINOR = 3
-    PATCH = 3
+    MAJOR = 1
+    MINOR = 0
+    PATCH = 0
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

ofx.gemspec

@@ -24,8 +24,5 @@ Gem::Specification.new do |s|
   s.require_paths = ['lib']
   s.licenses      = ['MIT']
 
-  s.add_dependency 'nokogiri', '~> 1.13.1'
-  s.add_development_dependency 'byebug', '~> 11.1.3'
-  s.add_development_dependency 'rake', '~> 13.0.6'
-  s.add_development_dependency 'rspec', '~> 3.10'
+  s.add_dependency 'nokogiri', '>= 1.13.1'
 end

spec/ofx/ofx_parser_spec.rb

@@ -28,7 +28,7 @@
 
   it "should work with UTF8 and Latin1 encodings" do
     @ofx = OFX::Parser::Base.new("spec/fixtures/utf8.ofx")
-    @ofx.content.should == open("spec/fixtures/utf8.ofx").read
+    @ofx.content.should == open("spec/fixtures/utf8.ofx", encoding: 'UTF-8').read
   end
 
   it "should set body" do