Fix SNS throttling error finding SNS topics #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move both files to the project root. Remove specific gem versions from Dockerfile, and rely on those specified in the gemspec and Gemfile. Fix path in GitHub Actions workflow after moving docker-compose.yml.
Use the `Aws::SNS::Resource#topics` to search the topics instead of the `Aws::SNS::Client#list_topics`. This should hopefully remove the intermittent AWS SNS throttling error seen on deployment.
ianoxley
changed the title
adamgeorgeson
previously approved these changes
Aug 8, 2023
.github/workflows/rspec.yml
Outdated
| docker-compose up -d | ||
| docker exec testrunner bash -c "cd src && bundle install && bundle exec rspec && exit" | ||
| docker-compose up -d --build | ||
| docker exec testrunner bash -c "bundle exec rspec && exit" |
There was a problem hiding this comment.
Is && exit here to try and control the exit code?
There was a problem hiding this comment.
I don't know TBH 🤷♂️
I did change this to use docker-compose run in dae4e9e instead.
There was a problem hiding this comment.
Ah yeah, it would have been due to using docker exec, to exit the container.
adamgeorgeson
previously approved these changes
Aug 8, 2023
jlongridge
previously approved these changes
Aug 8, 2023
The `client` passed to the constructor looks like it'll be an eventq `AwsQueueClient` rather than an AWS SNS client. So create the `Resource` using that client's `#sns` method.
This reverts commit 68c96de.
Use the given argument or create a new `Resource`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
Aws::SNS::Client#list_topicscall withAws::SNS::Resource#topicswhen iterating through topics.The former can be subject to rate limiting, whereas the documentation for the latter makes no mention of it being subject to rate limiting.
Also: