Skip to content

Commit

Permalink
bugfix for namespacing
Browse files Browse the repository at this point in the history
  • Loading branch information
vaughanbrittonsage committed Oct 17, 2016
1 parent 333cc3f commit 799cc7d
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 13 deletions.
6 changes: 6 additions & 0 deletions eventq_aws/lib/eventq_aws.rb
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,11 @@ def self.create_event_type(event_type)
end
return "#{EventQ.namespace}-#{event_type}"
end
def self.create_queue_name(queue_name)
if EventQ.namespace == nil
return queue_name
end
return "#{EventQ.namespace}-#{queue_name}"
end
end

6 changes: 2 additions & 4 deletions eventq_aws/lib/eventq_aws/aws_eventq_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@ def initialize(options)

def raise_event(event_type, event)

_event_type = EventQ.create_event_type(event_type)

topic_arn = @client.get_topic_arn(_event_type)
topic_arn = @client.get_topic_arn(event_type)

qm = new_message
qm.content = event
qm.type = _event_type
qm.type = event_type

serialization_provider = @serialization_manager.get_provider(EventQ::Configuration.serialization_provider)

Expand Down
12 changes: 8 additions & 4 deletions eventq_aws/lib/eventq_aws/aws_queue_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -30,21 +30,25 @@ def initialize(options = {})
end

def get_topic_arn(event_type)
return "arn:aws:sns:#{@aws_region}:#{@aws_account}:#{aws_safe_name(event_type)}"
_event_type = EventQ.create_event_type(event_type)
return "arn:aws:sns:#{@aws_region}:#{@aws_account}:#{aws_safe_name(_event_type)}"
end

def get_queue_arn(queue)
return "arn:aws:sqs:#{@aws_region}:#{@aws_account}:#{aws_safe_name(queue.name)}"
_queue_name = EventQ.create_queue_name(queue.name)
return "arn:aws:sqs:#{@aws_region}:#{@aws_account}:#{aws_safe_name(_queue_name)}"
end

def create_topic_arn(event_type)
response = @sns.create_topic({ name: aws_safe_name(event_type) })
_event_type = EventQ.create_event_type(event_type)
response = @sns.create_topic({ name: aws_safe_name(_event_type) })
return response.topic_arn
end

def get_queue_url(queue)
_queue_name = EventQ.create_queue_name(queue.name)
response= @sqs.get_queue_url({
queue_name: aws_safe_name(queue.name),
queue_name: aws_safe_name(_queue_name),
queue_owner_aws_account_id: @aws_account,
})
return response.queue_url
Expand Down
6 changes: 4 additions & 2 deletions eventq_aws/lib/eventq_aws/aws_queue_manager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@ def get_queue(queue)
end

def create_queue(queue)
_queue_name = EventQ.create_queue_name(queue.name)
response = @client.sqs.create_queue({
queue_name: queue.name,
queue_name: _queue_name,
attributes: {
VISIBILITY_TIMEOUT => 300.to_s #5 minutes
}
Expand All @@ -52,7 +53,8 @@ def drop_topic(event_type)
end

def queue_exists?(queue)
return @client.sqs.list_queues({ queue_name_prefix: queue.name }).queue_urls.length > 0
_queue_name = EventQ.create_queue_name(queue.name)
return @client.sqs.list_queues({ queue_name_prefix: _queue_name }).queue_urls.length > 0
end

def update_queue(queue)
Expand Down
3 changes: 1 addition & 2 deletions eventq_aws/lib/eventq_aws/aws_subscription_manager.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ def initialize(options)

def subscribe(event_type, queue)

_event_type = EventQ.create_event_type(event_type)
topic_arn = @client.create_topic_arn(_event_type)
topic_arn = @client.create_topic_arn(event_type)

q = @manager.get_queue(queue)
queue_arn = @client.get_queue_arn(queue)
Expand Down
2 changes: 1 addition & 1 deletion eventq_aws/lib/eventq_aws/version.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module EventQ
module Amazon
VERSION = "1.6.0"
VERSION = "1.6.1"
end
end

0 comments on commit 799cc7d

Please sign in to comment.