Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frozen theme and profile): Add progress tracker tokens for frozen theme, and amend profile tokens, based on user feedback. #429

Merged
merged 4 commits into from
Feb 4, 2025
Merged

feat(frozen theme and profile): Add progress tracker tokens for frozen theme, and amend profile tokens, based on user feedback. #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f161c76
fix(frozen progress tracker): Add tokens for progress tracker in froz…
clairedenning Feb 4, 2025
3e54a48
fix(profile): Decrease value of profile.size.inside.XXL after user fe…
clairedenning Feb 4, 2025
383f083
reverting claire's commit to previous version
ljemmo Feb 4, 2025
70c4d4d
fix(profile): Decrease value of profile.size.inside.XXL following use…
clairedenning Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion data/tokens/components/profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
},
"XXL": {
"$type": "sizing",
"$value": "{global.size.micro.M} * 13",
"$value": "{global.size.micro.M} * 9",
"$description": "XXL Portraits"
}
}
Expand Down
12 changes: 12 additions & 0 deletions data/tokens/context/frozenproduct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,18 @@
},
"progress": {
"color": {
"bg-default": {
"$type": "color",
"$value": "{modes.color.interactive.progress.frozen.bg-alt}"
},
"border-default": {
"$type": "color",
"$value": "{modes.color.generic.fg.frozen.soft}"
},
"fg-default": {
"$type": "color",
"$value": "{modes.color.interactive.monochrome.generic.frozen.active2}"
},
"loader": {
"bg-default": {
"$type": "color",
Expand Down
25 changes: 25 additions & 0 deletions data/tokens/modes/dark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,22 @@
},
"$type": "color",
"$value": "{modes.color.generic.fg.nought}"
},
"frozen": {
"soft": {
"$extensions": {
"studio.tokens": {
"modify": {
"type": "mix",
"value": "0.32",
"space": "lch",
"color": "{modes.color.modifier.contrastMore} "
}
}
},
"$type": "color",
"$value": "{modes.color.generic.fg.nought}"
}
}
},
"backdrop": {
Expand Down Expand Up @@ -771,6 +787,11 @@
"$type": "color",
"$value": "{modes.color.interactive.monochrome.generic.active}",
"$description": "Used within frozen table"
},
"active2": {
"$type": "color",
"$value": "{modes.color.interactive.monochrome.generic.active}",
"$description": "progress tracker"
}
}
},
Expand Down Expand Up @@ -1013,6 +1034,10 @@
"bg": {
"$type": "color",
"$value": "{modes.color.interactive.progress.bg}"
},
"bg-alt": {
"$type": "color",
"$value": "{modes.color.interactive.progress.bg}"
}
}
}
Expand Down
27 changes: 27 additions & 0 deletions data/tokens/modes/light.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,13 @@
},
"$type": "color",
"$value": "{modes.color.generic.fg.nought}"
},
"frozen": {
"soft": {
"$type": "color",
"$value": "{modes.color.status.neutral.frozen.default}",
"$description": "frozen progress tracker border"
}
}
},
"backdrop": {
Expand Down Expand Up @@ -807,6 +814,11 @@
"$type": "color",
"$value": "{primitives.colors.navy}",
"$description": "Used within frozen table"
},
"active2": {
"$type": "color",
"$value": "{modes.color.generic.fg.frozen.soft}",
"$description": "Frozen progress tracker"
}
}
},
Expand Down Expand Up @@ -1059,6 +1071,21 @@
},
"$type": "color",
"$value": "{primitives.colors.frozenJade}"
},
"bg-alt": {
"$extensions": {
"studio.tokens": {
"modify": {
"type": "mix",
"value": "0.75",
"space": "lch",
"color": "{modes.color.modifier.contrastLess}"
}
}
},
"$type": "color",
"$value": "{primitives.colors.navy}",
"$description": "progress tracker bg"
}
}
}
Expand Down