Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): Correct casing of @Sage scope #338

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

adrianbruntonsagecom
Copy link
Contributor

@adrianbruntonsagecom adrianbruntonsagecom commented Oct 4, 2023

When importing CSS using the documented path of @import "@Sage/design-tokens/css/base.css";, a vite build results in an error:

Unable to resolve @import "@Sage/design-tokens/css/base.css" from /home/runner/work/carbon-angular/carbon-angular/src/styles
[vite:css] [postcss] ENOENT: no such file or directory, open '@Sage/design-tokens/css/base.css'

This was due to a casing issue in case sensitive operating systems - it occurred in GitHub actions running under a linux environment. This change amends the documentation to be consistent by specifying a lower cased "@Sage" scope.

@adrianbruntonsagecom adrianbruntonsagecom changed the title docs: Correct casing of @Sage scope docs(readme): Correct casing of @Sage scope Oct 4, 2023
@druhill druhill merged commit 651730c into Sage:master Nov 24, 2023
1 check passed
@carbonci
Copy link
Collaborator

🎉 This PR is included in version 4.32.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@adrianbruntonsagecom adrianbruntonsagecom deleted the amend-docs-sage-casing branch March 6, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants