Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the docstring for setPermissions to be clearer #1164

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update the docstring for setPermissions to be clearer #1164

merged 1 commit into from
Feb 4, 2025
+36 −9

Conversation

BryanFauble
Copy link
Contributor

Problem:

  1. The docstring for this function is not clear what the 2 given parameters do

Solution:

  1. Add a more verbose docstring around these 2 function parameters

@BryanFauble BryanFauble requested a review from a team as a code owner February 4, 2025 16:19
jaymedina
jaymedina approved these changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BryanFauble BryanFauble merged commit 645f7f5 into develop Feb 4, 2025
15 of 18 checks passed
@BryanFauble BryanFauble deleted the clarify-docstring-of-set-permissions branch February 4, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaymedina jaymedina jaymedina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BryanFauble @jaymedina