Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix reversed package dependencies #2

Merged
merged 2 commits into from
Mar 19, 2024
Merged

chore: fix reversed package dependencies #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8012b69
chore: fix reversed package dependencies
MaikoTan Mar 19, 2024
d7dd315
chore: remove peer dependence
SaarChaffee Mar 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions packages/landosol-roster/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@
}
},
"peerDependencies": {
"koishi": "^4.17.1",
"koishi-plugin-pcr": "^1.0.0"
},
"devDependencies": {
"koishi-plugin-pcr": "^1.0.0"
"koishi": "^4.17.1"
}
}
6 changes: 4 additions & 2 deletions packages/pcr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,12 @@
}
},
"peerDependencies": {
"koishi": "^4.17.1"
"koishi": "^4.17.1",
"koishi-plugin-pcr-landosol-roster": "^0.0.2"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

landosol-roster 应该是可选依赖才对吧，要在 peer 里吗

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

在 peer 里面就变成了必须依赖了，这里不能加

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, in that case, you should add a peerDependenciesMeta instead of removing it.

"peerDependencies": {
  "koishi-plugin-pcr-landosol-roster": {
    "optional": true
  }
}

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

还有这种东西

},
"devDependencies": {
"koishi-plugin-canvas": "^0.2.2"
"koishi-plugin-canvas": "^0.2.2",
"koishi-plugin-pcr-landosol-roster": "^0.0.2"
},
"dependencies": {
"file-type": "^16.5.4"
Expand Down