chore: fix reversed package dependencies #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR HealthBuild ✅Detailsyarn run v1.22.22
$ yakumo build
Done in 2.06s. |
SaarChaffee
approved these changes
Mar 19, 2024
packages/pcr/package.json
Outdated
| @@ -49,10 +49,12 @@ | |||
| } | |||
| }, | |||
| "peerDependencies": { | |||
| "koishi": "^4.17.1" | |||
| "koishi": "^4.17.1", | |||
| "koishi-plugin-pcr-landosol-roster": "^0.0.2" | |||
There was a problem hiding this comment.
landosol-roster 应该是可选依赖才对吧，要在 peer 里吗
There was a problem hiding this comment.
Well, in that case, you should add a peerDependenciesMeta instead of removing it.
"peerDependencies": {
"koishi-plugin-pcr-landosol-roster": {
"optional": true
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.