✨ Add support for read_only field of mounts and binds
#89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linkdd
force-pushed
the
mount-bind-read_only
branch
from
4dc6a43 to
58bbfb0
Compare
lvenier
approved these changes
May 3, 2024
fanshan
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decision Record
Counterpart of SaaShup/netbox-docker-plugin#118
By default, we used to create mounts (from volumes or binds) with "read write" permissions. Now, we use the new field
read_onlyfrom theMountandBindmodels of the Netbox plugin.Changes
read_onlyfield onMountandBindin Netbox using theHostConfig.Mounts[].ReadOnlypropertyHostConfig.Mounts[].ReadOnlyproperty based on theread_onlyfield ofMountandBindmodelsHostConfig.Mounts[].RWfield (does not exist in Docker Engine API)HostConfig.Mounts[].Modefield (does not exist in Docker Engine API)