Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache check #1289

Closed
wants to merge 9 commits into from
Closed

Add cache check #1289

wants to merge 9 commits into from

Conversation

jesusbv
Copy link
Collaborator

@jesusbv jesusbv commented Feb 21, 2025

Description

When a BYOS or HYBRID system activates a product with SCC we check first if the registration code use for that activation is in the cache for that product

If there is a match in the cache and the registration code is active we do not reach to SCC, update the cache and update the system pubcloud_reg_code if reg code is new or different

If there is no match in the cache we call SCC, update the cache and update the system pubcloud_reg_code if it's new or different

If the registration code is inactive, we do not follow with the activation

There is also the registry cache handling logic included

  • Related Issue / Ticket / Trello card:

How to test

Trying to activate a product on a BYOS instance within the cache being valid should not reach to SCC
Trying to activate a product on a BYOS instance when the cache expired should reach to SCC

Change Type

Please select the correct option.

  • Bug Fix (a non-breaking change which fixes an issue)
  • New Feature (a non-breaking change which adds new functionality)
  • Documentation Update (a change which only updates documentation)

Checklist

Please check off each item if the requirement is met.

  • I have reviewed my own code and believe that it's ready for an external review.
  • I have provided comments for any hard-to-understand code.
  • I have documented the MANUAL.md file with any changes to the user experience.
  • If my changes are non-trivial, I have added a changelog entry to notify users at package/obs/rmt-server.changes.

Review

Please check out our review guidelines
and get in touch with the author to get a shared understanding of the change.

@jesusbv jesusbv force-pushed the activate-product-cache branch from 98ccbb1 to 9b26119 Compare February 21, 2025 12:22
@jesusbv jesusbv closed this Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant