Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HAL_PCD_SetTestMode() doesn't clear register bits before setting them #10

Open
kevinpt opened this issue Jul 10, 2024 · 1 comment
Open

HAL_PCD_SetTestMode() doesn't clear register bits before setting them #10

kevinpt opened this issue Jul 10, 2024 · 1 comment
Assignees
@ALABSTM
Labels
bug Something isn't working hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and logged into the internal bug tracking system usb Universal Serial Bus

Comments

@kevinpt
Copy link

kevinpt commented Jul 10, 2024

Describe the set-up

  • STM32F723
  • IDE 1.14.1, HAL 1.3.1

Describe the bug
Inspection of the code for HAL_PCD_SetTestMode() shows that the RW bits for TCTL in the OTG_DCTL register are not cleared before setting them. This function will work on the first usage but future changes to test mode will garble the bits.

For completeness there should probably also be a define for test mode disabled (0U).
@RJMSTM RJMSTM added bug Something isn't working hal HAL-LL driver-related issue or pull-request. usb Universal Serial Bus labels Jul 12, 2024
@ALABSTM ALABSTM added the internal bug tracker Issue confirmed and logged into the internal bug tracking system label Jul 12, 2024
@ALABSTM
Copy link
Collaborator

ALABSTM commented Jul 12, 2024

ST Internal Reference: 186507

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ALABSTM ALABSTM

Labels
bug Something isn't working hal HAL-LL driver-related issue or pull-request. internal bug tracker Issue confirmed and logged into the internal bug tracking system usb Universal Serial Bus
Projects
stm32cube-mcu-hal-dashboard
Status: Analyzed
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevinpt @ALABSTM @RJMSTM