Try less and more when pager is not found (on macOS?) #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #711 Reported-by: Ryan Carsten Schmidt
orgads
requested changes
Apr 5, 2024
| @@ -756,7 +756,15 @@ static char* wrap(const char* in, int offset, int size) | |||
| /* If stdout is a TTY, wrap stdout in a call to PAGER (generally less(1)). | |||
| * Returns a pid_t you'll have to pass to end_pager(). */ | |||
| static pid_t begin_pager() { | |||
| char pager[15] = "/usr/bin/pager"; | |||
| char const *pager_options[4] = { | |||
There was a problem hiding this comment.
std::vector<std::string>? Iteration is easier, and you won't need a copy, you can pass &opt[0].
There was a problem hiding this comment.
🤷
I guess we should do more c++. Be my guest 😬
I assume we won't need a copy because it is a copy already.
orgads
approved these changes
Apr 5, 2024
|
closed by 3242112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #711
Reported-by: Ryan Carsten Schmidt