@W-17621812: Update _get_required_permission_types to handle SELECT operations #3870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditya-balachander
requested review from
vsbharath,
jkasturi-sf and
lakshmi2506
vsbharath
reviewed
Jan 17, 2025
| response = self.sf.restful( | ||
| requests.utils.requote_uri(f"query/?q={select_query}"), method="GET" | ||
| ) | ||
| response = self.sf.restful(f"query/?q={quote(select_query)}", method="GET") |
There was a problem hiding this comment.
Does this select_query has mulltiple params? if so can we use urllib.parse.urlencode for encoding multiple params ?
There was a problem hiding this comment.
No @vsbharath,
It is just a string such as SELECT Id FROM Account WHERE Name LIKE 'Account%'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
W-17621812
Issue:
requote_urifunction did not handle the%character correctly when URL-encoding queries, leading to invalid query formats when passed to the Salesforce API. Specifically, it did not encode%as%25, causing issues in query string formatting. (Example and associated Error given in W-17621812 under point 1)SELECToperations was incorrectly defaulting tocreateable. As a result, fields were unnecessarily required to becreateable, even thoughSELECToperations only require them to bequeryable.Changes:
_get_required_permission_typesfunction, used in mapping validation, to verifyqueryablepermissions instead ofcreateableforSELECToperations.requote_uriwithurllib.parse.quoteto ensure proper URL encoding of special characters, including%, which is now correctly encoded as%25. This ensures the query string is properly formatted for the Salesforce API.