Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization Columns - Part 1 #26

Open
wants to merge 29 commits into
base: main
Choose a base branch
from
Open

Conversation

crutan
Copy link
Contributor

@crutan crutan commented Mar 7, 2025

This PR includes a new approach to the property/taxlot tabs along with sidebar navigation for organization columns that supports the splitting of Column Settings and Column Mapping into separate subsections.

image

The tabs route to specific components, and the sidebar navigation remains active for both individual tabs.

Currently the first three sections are functional:

  • column list, with edit and delete column functionality
  • geocoding order with drag and drop column ordering
  • data types for setting type on the extra data columns.

Work TBD:

Column renaming

Import settings will contain merge protection, recognize empty settings and exclude from uniqueness settings for all columns.

Matching Criteria will encompass the ability to add or remove match criteria, as well as the preview generation

Mapping Profiles, and Column Mapping settings

@crutan crutan requested a review from perryr16 March 7, 2025 22:42
Copy link
Contributor

@perryr16 perryr16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the refactored column settings pages as several more purposeful pages.

I support the approach for property and tax lot tabs. If we decide to go with this approach we should be consistent across the app and update the existing pages that use tabs.

@crutan crutan requested review from axelstudios and kflemin March 11, 2025 17:06
Copy link
Contributor

@kflemin kflemin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants