Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org Settings -> Default display fields #16

Merged
merged 4 commits into from
Feb 17, 2025
Merged

Conversation

crutan
Copy link
Contributor

@crutan crutan commented Feb 15, 2025

Adds a column service to go fetch columns per organization
Adds default display fields page, utilizes multi select for x/y axis fields

@crutan crutan requested a review from perryr16 February 15, 2025 01:46
taxLotColumns$ = this._taxLotColumns.asObservable()

constructor() {
// Fetch current org data whenever user org id changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this pattern, I'm going to implement it in the other existing services

Copy link
Contributor

@perryr16 perryr16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, love the column service.

My only suggestion would be to display the columns in a vertical arrangment so they arent cut off
Screenshot 2025-02-17 at 9 07 16 AM

@perryr16 perryr16 merged commit 78fc18e into main Feb 17, 2025
2 checks passed
@perryr16 perryr16 deleted the crutan/default-display-fields branch February 17, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants